Page MenuHomePhabricator

Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`
ClosedPublic

Authored by JohnTitor on Jun 10 2022, 9:37 AM.

Details

Summary

getCurrentFile here causes an assertion on some condition.
getCurrentFileOrBufferName is preferrable instead.

llvm#55950

Diff Detail

Event Timeline

JohnTitor created this revision.Jun 10 2022, 9:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2022, 9:37 AM
JohnTitor requested review of this revision.Jun 10 2022, 9:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2022, 9:37 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

LGTM but can you try re-running the pre-commit CI?

I've re-triggered it several times but it shows the same failure, maybe they're valid?

tbaeder accepted this revision.Jun 18 2022, 12:21 AM

Those are all libomp tests, I doubt they are related. I think it's fine to just push this.

This revision is now accepted and ready to land.Jun 18 2022, 12:21 AM

Alright, let's go ahead then.

This revision was landed with ongoing or failed builds.Jun 18 2022, 7:48 AM
This revision was automatically updated to reflect the committed changes.