[NFC] Suggest Release mode in clang GettingStarted.html

[xgupta]

Summary

This fix https://github.com/llvm/llvm-project/issues/23841.
Lots of beginners are not of aware of this option do suggesting it here
would be helpful.

[thieta]

Thanks for fixing - but it's not completely accurate right now.

clang/www/get_started.html

72

This isn't correct - invoking cmake without a CMAKE_BUILD_TYPE argument will just print an error. I would fix the command line below to include -DCMAKE_BUILD_TYPE=Release and have a comment saying switch Release to Debug if you need a debug build.

[aaron.ballman]

clang/www/get_started.html

72

+1 to most of this, but I'd have the comment say something along the lines of "See https://llvm.org/docs/CMake.html#frequently-used-cmake-variables for more options".

[xgupta]

Address comments

[xgupta]

clang/www/get_started.html

72

I hope 'most of this' also includes making changes to the default suggestion of -DCMAKE_BUILD_TYPE :)

[aaron.ballman]

Looks pretty close, just some minor nits from me.

clang/www/get_started.html

72

I hope 'most of this' also includes making changes to the default suggestion of -DCMAKE_BUILD_TYPE :)

Heh, it did! :-)

72–78

[aaron.ballman]

LGTM aside from a missing comma (that can be fixed when landing). But you should give @thieta a chance to chime in before landing.

clang/www/get_started.html

72

Looks like this was missed with the other changes.

[thieta]

Looks fine to me. Thanks for fixing!

[xgupta]

Thank you for review! Committed in https://reviews.llvm.org/rGa01579ad0a1bde4d90f4fb656f07586c3097428a.

clang/www/get_started.html

<ul>
     </li>
   </ul>
   </li>
   <li>Build LLVM and Clang:
   <ul>
     <li><tt>cd llvm-project</tt></li>
     <li><tt>mkdir build</tt> (in-tree build is not supported)</li>
     <li><tt>cd build</tt></li>
-    <li><tt>cmake -DLLVM_ENABLE_PROJECTS=clang -G "Unix Makefiles" ../llvm</tt></li>
+    <li>This builds both LLVM and Clang in release mode. Alternatively if
+        you need a debug build, switch Release to Debug. See
+        <a href="https://llvm.org/docs/CMake.html#frequently-used-cmake-variables">frequently used cmake variables</a>
+        for more options.
+    </li>
+    <li><tt>cmake -DLLVM_ENABLE_PROJECTS=clang -DCMAKE_BUILD_TYPE=Release -G "Unix Makefiles" ../llvm</tt></li>
     <li><tt>make</tt></li>
-    <li>This builds both LLVM and Clang for debug mode.</li>
     <li>Note: For subsequent Clang development, you can just run
         <tt>make clang</tt>.</li>
     <li>CMake allows you to generate project files for several IDEs: Xcode,
         Eclipse CDT4, CodeBlocks, Qt-Creator (use the CodeBlocks generator),
         KDevelop3. For more details see
         <a href="https://llvm.org/docs/CMake.html">Building LLVM with CMake</a>
         page.</li>
   </ul>