The pipe2(2) call is supported on NetBSD

[krytarowski]

Summary

Linux and NetBSD versions are compatible, modulo flag values:

• O_CLOEXEC and O_NONBLOCK are the same,
• O_NOSIGPIPE on NetBSD,
• O_DIRECT on Linux.

[emaste]

source/Host/posix/PipePosix.cpp

39 ↗

(On Diff #34398)

My preference is that we don't repeat the list of platforms in the comments when we have cases like this - perhaps just change to // pipe2 is supported by a limited set of platforms or so?

Presumably you're only interested in recent NetBSD versions while getting support working?

[krytarowski]

source/Host/posix/PipePosix.cpp

39 ↗

(On Diff #34398)

I will rediff the comment.

Yes, I'm just interested with the -current version. I'm working with the NetBSD to add missing bits to extend the system capabilities for larger possibe lldb support.

[krytarowski]

rediff the comment

[krytarowski]

Please commit it if it's OK.

lldb/trunk/source/Host/posix/PipePosix.cpp

 
 using namespace lldb;
 using namespace lldb_private;
 
 int PipePosix::kInvalidDescriptor = -1;
 
 enum PIPES { READ, WRITE }; // Constants 0 and 1 for READ and WRITE
 
-// pipe2 is supported by Linux, FreeBSD v10 and higher.
+// pipe2 is supported by a limited set of platforms
 // TODO: Add more platforms that support pipe2.
-#if defined(__linux__) || (defined(__FreeBSD__) && __FreeBSD__ >= 10)
+#if defined(__linux__) || (defined(__FreeBSD__) && __FreeBSD__ >= 10) || defined(__NetBSD__)
 #define PIPE2_SUPPORTED 1
 #else
 #define PIPE2_SUPPORTED 0
 #endif
 
 namespace
 {