This is an archive of the discontinued LLVM Phabricator instance.

Differential D12746

The pipe2(2) call is supported on NetBSD
ClosedPublic

Authored by krytarowski on Sep 9 2015, 6:15 PM.

Details

Reviewers
sas
joerg
Commits
rG37366e569811: The pipe2(2) call is supported on NetBSD
rLLDB247568: The pipe2(2) call is supported on NetBSD
rL247568: The pipe2(2) call is supported on NetBSD
Summary

Linux and NetBSD versions are compatible, modulo flag values:

  • O_CLOEXEC and O_NONBLOCK are the same,
  • O_NOSIGPIPE on NetBSD,
  • O_DIRECT on Linux.

Diff Detail

Repository
rL LLVM

Event Timeline

krytarowski updated this revision to Diff 34398.Sep 9 2015, 6:15 PM
krytarowski retitled this revision from to The pipe2(2) call is supported on NetBSD.
krytarowski updated this object.
krytarowski added a reviewer: joerg.
krytarowski set the repository for this revision to rL LLVM.
krytarowski added a subscriber: lldb-commits.
sas accepted this revision.Sep 10 2015, 9:59 AM
sas added a reviewer: sas.
This revision is now accepted and ready to land.Sep 10 2015, 9:59 AM
emaste added a subscriber: emaste.Sep 10 2015, 4:44 PM
emaste added inline comments.
source/Host/posix/PipePosix.cpp
39

My preference is that we don't repeat the list of platforms in the comments when we have cases like this - perhaps just change to // pipe2 is supported by a limited set of platforms or so?

Presumably you're only interested in recent NetBSD versions while getting support working?

krytarowski added inline comments.Sep 10 2015, 4:49 PM
source/Host/posix/PipePosix.cpp
39

I will rediff the comment.

Yes, I'm just interested with the -current version. I'm working with the NetBSD to add missing bits to extend the system capabilities for larger possibe lldb support.

krytarowski updated this revision to Diff 34512.Sep 10 2015, 4:54 PM
krytarowski edited edge metadata.

rediff the comment

krytarowski added a comment.Sep 14 2015, 4:14 AM

Please commit it if it's OK.

Closed by commit rL247568: The pipe2(2) call is supported on NetBSD (authored by emaste). · Explain WhySep 14 2015, 8:14 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
source/
Host/
posix/
4 lines

Diff 34512

source/Host/posix/PipePosix.cpp

Show All 30 Lines
using namespace lldb; using namespace lldb;
using namespace lldb_private; using namespace lldb_private;
int PipePosix::kInvalidDescriptor = -1; int PipePosix::kInvalidDescriptor = -1;
enum PIPES { READ, WRITE }; // Constants 0 and 1 for READ and WRITE enum PIPES { READ, WRITE }; // Constants 0 and 1 for READ and WRITE
// pipe2 is supported by Linux, FreeBSD v10 and higher. // pipe2 is supported by a limited set of platforms
emasteUnsubmitted
Not Done
ReplyInline Actions

My preference is that we don't repeat the list of platforms in the comments when we have cases like this - perhaps just change to // pipe2 is supported by a limited set of platforms or so?

Presumably you're only interested in recent NetBSD versions while getting support working?

emaste: My preference is that we don't repeat the list of platforms in the comments when we have cases…
krytarowskiAuthorUnsubmitted
Not Done
ReplyInline Actions

I will rediff the comment.

Yes, I'm just interested with the -current version. I'm working with the NetBSD to add missing bits to extend the system capabilities for larger possibe lldb support.

krytarowski: I will rediff the comment. Yes, I'm just interested with the -current version. I'm working…
// TODO: Add more platforms that support pipe2. // TODO: Add more platforms that support pipe2.
#if defined(__linux__) || (defined(__FreeBSD__) && __FreeBSD__ >= 10) #if defined(__linux__) || (defined(__FreeBSD__) && __FreeBSD__ >= 10) || defined(__NetBSD__)
#define PIPE2_SUPPORTED 1 #define PIPE2_SUPPORTED 1
#else #else
#define PIPE2_SUPPORTED 0 #define PIPE2_SUPPORTED 0
#endif #endif
namespace namespace
{ {
▲ Show 20 Lines • Show All 388 Lines • Show Last 20 Lines