This is an archive of the discontinued LLVM Phabricator instance.

[gn build][Bazel] Port D127384
AbandonedPublic

Authored by abrachet on Jun 9 2022, 1:43 PM.

Details

Reviewers
thakis
gribozavr2

Diff Detail

Event Timeline

abrachet created this revision.Jun 9 2022, 1:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 9 2022, 1:43 PM
abrachet requested review of this revision.Jun 9 2022, 1:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 9 2022, 1:43 PM

This is a preemptive change for when D127384 lands

thakis accepted this revision.Jun 10 2022, 5:24 AM

Thanks! I did the gn part earlier today, but it should merge cleanly.

This revision is now accepted and ready to land.Jun 10 2022, 5:24 AM
thakis added inline comments.Jun 10 2022, 5:25 AM
llvm/utils/gn/build/driver_executable.gni
9

hold up, it's llvm-driver-template.cpp.in. now, with leading "llvm-", right? (Also below.)

abrachet abandoned this revision.Jun 10 2022, 8:48 AM
abrachet marked an inline comment as done.

This is no longer needed both builds have been ported already

llvm/utils/gn/build/driver_executable.gni
9

Indeed it was. I didn't actually try the patch locally, I just trusted myself to be able to read a file name properly :)