I checked this patch on my own build on RHEL 6. Regressions were OK.
Please check it in if it's OK, because I don't have SVN write access.
Paths
| Differential D12741
[Clang] Fix Clang-tidy misc-use-override warnings, other minor fixes ClosedPublic Authored by Eugene.Zelenko on Sep 9 2015, 4:27 PM.
Details Summary I checked this patch on my own build on RHEL 6. Regressions were OK. Please check it in if it's OK, because I don't have SVN write access.
Diff Detail Event TimelineEugene.Zelenko retitled this revision from to [Clang] Fix Clang-tidy misc-use-override warnings, other minor fixes. Eugene.Zelenko updated this object. This revision is now accepted and ready to land.Sep 9 2015, 5:25 PM Closed by commit rL247218: Fix Clang-tidy misc-use-override warnings, other minor fixes (authored by hans). · Explain WhySep 9 2015, 5:26 PM This revision was automatically updated to reflect the committed changes. Comment Actions It seems this broke the build for some reason. I have reverted it in r247222. Example build breakages: http://lab.llvm.org:8011/builders/perf-x86_64-penryn-O3-polly-fast/builds/11687/steps/compile/logs/stdio, http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75/builds/24926 Comment Actions
Sorry, it was probably the LLVM side that broke things. I've reverted that too, in r247226. Someone suggested it's gcc 4.7 that's unhappy about something. I can try to take a look tomorrow. Comment Actions I'm sorry for making trouble. I don't have access to GCC 4.7. 4.8 build looks OK (not completed yet, but LLVM part didn't cause problems).
Revision Contents
Diff 34385 lib/Basic/Targets.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/ObjectFilePCHContainerOperations.cpp
lib/Driver/ToolChains.h
lib/Format/UnwrappedLineFormatter.cpp
lib/Frontend/PCHContainerOperations.cpp
|