This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Fixes CI after Jammy update.
ClosedPublic

Authored by Mordante on Jun 9 2022, 11:52 AM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rG075990236f8f: [libc++] Fixes CI after Jammy update.

Diff Detail

Event Timeline

Mordante created this revision.Jun 9 2022, 11:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 9 2022, 11:52 AM
Mordante requested review of this revision.Jun 9 2022, 11:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 9 2022, 11:52 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

Note I intend to land this when the CI passes. Making a review gives faster feedback.

libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp
15

Only 11 so I can see whether GCC-12 has the same issue. (I've a patch prepared for GCC-12.)

philnik accepted this revision.Jun 9 2022, 11:54 AM
philnik added a subscriber: philnik.

LGTM with comment applied.

libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp
15

Could you put this as it's own // UNSUPPORTED with it's own (correct) comment?

This revision is now accepted and ready to land.Jun 9 2022, 11:54 AM
Mordante marked an inline comment as done.Jun 9 2022, 12:50 PM

Thanks for the review!

libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp
15

I've done that. It also seems to fail for clang 13 :-( So I wonder in how many CIs this is actually tested. But it seems that was already an existing issue.

PS: the GCC-12 patch is already made I just want to wait for the CI to be stable to test it.

ldionne added inline comments.
libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp
15

Sorry, I missed this patch but I just did this in 353324eb1458f56e11ff63d820ff78ea287f3bf3.

This revision was landed with ongoing or failed builds.Jun 9 2022, 12:57 PM
This revision was automatically updated to reflect the committed changes.
Mordante marked an inline comment as done.