Details
- Reviewers
philnik - Group Reviewers
Restricted Project - Commits
- rG075990236f8f: [libc++] Fixes CI after Jammy update.
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Note I intend to land this when the CI passes. Making a review gives faster feedback.
libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp | ||
---|---|---|
15 | Only 11 so I can see whether GCC-12 has the same issue. (I've a patch prepared for GCC-12.) |
LGTM with comment applied.
libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp | ||
---|---|---|
15 | Could you put this as it's own // UNSUPPORTED with it's own (correct) comment? |
Thanks for the review!
libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp | ||
---|---|---|
15 | I've done that. It also seems to fail for clang 13 :-( So I wonder in how many CIs this is actually tested. But it seems that was already an existing issue. PS: the GCC-12 patch is already made I just want to wait for the CI to be stable to test it. |
libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp | ||
---|---|---|
15 | Sorry, I missed this patch but I just did this in 353324eb1458f56e11ff63d820ff78ea287f3bf3. |
Only 11 so I can see whether GCC-12 has the same issue. (I've a patch prepared for GCC-12.)