This is an archive of the discontinued LLVM Phabricator instance.

[CSSPGO][Preinliner] Set default value of sample-profile-inline-limit-max to 3000
ClosedPublic

Authored by hoy on Jun 8 2022, 11:50 AM.

Details

Summary

The default value of sample-profile-inline-limit-max is defined as 10000 in sampleprofile.cpp. This is too big for cspreinliner which works with assembly size instead of IR size. The value 3000 turns out to be a good tradeoff. Compared to the value 10000, 3000 gives as good performance and code size, but lower build time.

Diff Detail

Event Timeline

hoy created this revision.Jun 8 2022, 11:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2022, 11:50 AM
Herald added subscribers: modimo, wenlei. · View Herald Transcript
hoy requested review of this revision.Jun 8 2022, 11:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2022, 11:50 AM
wlei accepted this revision.Jun 8 2022, 11:52 AM

LGTM.

This revision is now accepted and ready to land.Jun 8 2022, 11:52 AM
wenlei accepted this revision.Jun 8 2022, 11:52 AM
This revision was landed with ongoing or failed builds.Jun 8 2022, 12:10 PM
This revision was automatically updated to reflect the committed changes.