This is an archive of the discontinued LLVM Phabricator instance.

Differential D127129

[libc] Fix cmake compatibility issue with list(POP_FRONT).
ClosedPublic

Authored by lntue on Jun 6 2022, 10:31 AM.

Details

Reviewers
sivachandra
Commits
rG667863d8a8d7: [libc] Fix cmake compatibility issue with list(POP_FRONT).
Summary

list(POP_FRONT) is only added to cmake in 3.15, while our base line
version is 3.13

Diff Detail

Event Timeline

lntue created this revision.Jun 6 2022, 10:31 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 6 2022, 10:31 AM
Herald added subscribers: ecnelises, tschuett, mgorny. · View Herald Transcript
lntue requested review of this revision.Jun 6 2022, 10:31 AM
sivachandra accepted this revision.Jun 6 2022, 10:35 AM
This revision is now accepted and ready to land.Jun 6 2022, 10:35 AM
This revision was landed with ongoing or failed builds.Jun 6 2022, 10:36 AM
Closed by commit rG667863d8a8d7: [libc] Fix cmake compatibility issue with list(POP_FRONT). (authored by lntue). · Explain Why
This revision was automatically updated to reflect the committed changes.
lntue added a commit: rG667863d8a8d7: [libc] Fix cmake compatibility issue with list(POP_FRONT)..
Harbormaster completed remote builds in B168095: Diff 434523.Jun 6 2022, 10:36 AM

Revision Contents

Diff 434525

libc/cmake/modules/LLVMLibCLibraryRules.cmake

Show First 20 Lines • Show All 201 Lines • ▼ Show 20 Lines create_header_library(
${target_name} ${target_name}
DEPENDS ${EXPAND_FLAGS_DEPENDS} DEPENDS ${EXPAND_FLAGS_DEPENDS}
FLAGS ${EXPAND_FLAGS_FLAGS} FLAGS ${EXPAND_FLAGS_FLAGS}
${EXPAND_FLAGS_UNPARSED_ARGUMENTS} ${EXPAND_FLAGS_UNPARSED_ARGUMENTS}
) )
return() return()
endif() endif()
list(POP_FRONT flags flag) list(GET flags 0 flag)
list(REMOVE_AT flags 0)
extract_flag_modifier(${flag} real_flag modifier) extract_flag_modifier(${flag} real_flag modifier)
if(NOT "${modifier}" STREQUAL "NO") if(NOT "${modifier}" STREQUAL "NO")
expand_flags_for_header_library( expand_flags_for_header_library(
${target_name} ${target_name}
"${flags}" "${flags}"
DEPENDS ${EXPAND_FLAGS_DEPENDS} IGNORE_MARKER DEPENDS ${EXPAND_FLAGS_DEPENDS} IGNORE_MARKER
FLAGS ${EXPAND_FLAGS_FLAGS} IGNORE_MARKER FLAGS ${EXPAND_FLAGS_FLAGS} IGNORE_MARKER
▲ Show 20 Lines • Show All 63 Lines • Show Last 20 Lines

libc/cmake/modules/LLVMLibCObjectRules.cmake

Show First 20 Lines • Show All 120 Lines • ▼ Show 20 Lines create_object_library(
${target_name} ${target_name}
DEPENDS ${EXPAND_FLAGS_DEPENDS} DEPENDS ${EXPAND_FLAGS_DEPENDS}
FLAGS ${EXPAND_FLAGS_FLAGS} FLAGS ${EXPAND_FLAGS_FLAGS}
${EXPAND_FLAGS_UNPARSED_ARGUMENTS} ${EXPAND_FLAGS_UNPARSED_ARGUMENTS}
) )
return() return()
endif() endif()
list(POP_FRONT flags flag) list(GET flags 0 flag)
list(REMOVE_AT flags 0)
extract_flag_modifier(${flag} real_flag modifier) extract_flag_modifier(${flag} real_flag modifier)
if(NOT "${modifier}" STREQUAL "NO") if(NOT "${modifier}" STREQUAL "NO")
expand_flags_for_object_library( expand_flags_for_object_library(
${target_name} ${target_name}
"${flags}" "${flags}"
DEPENDS "${EXPAND_FLAGS_DEPENDS}" IGNORE_MARKER DEPENDS "${EXPAND_FLAGS_DEPENDS}" IGNORE_MARKER
FLAGS "${EXPAND_FLAGS_FLAGS}" IGNORE_MARKER FLAGS "${EXPAND_FLAGS_FLAGS}" IGNORE_MARKER
▲ Show 20 Lines • Show All 298 Lines • ▼ Show 20 Lines create_entrypoint_object(
${target_name} ${target_name}
DEPENDS ${EXPAND_FLAGS_DEPENDS} DEPENDS ${EXPAND_FLAGS_DEPENDS}
FLAGS ${EXPAND_FLAGS_FLAGS} FLAGS ${EXPAND_FLAGS_FLAGS}
${EXPAND_FLAGS_UNPARSED_ARGUMENTS} ${EXPAND_FLAGS_UNPARSED_ARGUMENTS}
) )
return() return()
endif() endif()
list(POP_FRONT flags flag) list(GET flags 0 flag)
list(REMOVE_AT flags 0)
extract_flag_modifier(${flag} real_flag modifier) extract_flag_modifier(${flag} real_flag modifier)
if(NOT "${modifier}" STREQUAL "NO") if(NOT "${modifier}" STREQUAL "NO")
expand_flags_for_entrypoint_object( expand_flags_for_entrypoint_object(
${target_name} ${target_name}
"${flags}" "${flags}"
DEPENDS "${EXPAND_FLAGS_DEPENDS}" IGNORE_MARKER DEPENDS "${EXPAND_FLAGS_DEPENDS}" IGNORE_MARKER
FLAGS "${EXPAND_FLAGS_FLAGS}" IGNORE_MARKER FLAGS "${EXPAND_FLAGS_FLAGS}" IGNORE_MARKER
▲ Show 20 Lines • Show All 123 Lines • Show Last 20 Lines

libc/cmake/modules/LLVMLibCTestRules.cmake

Show First 20 Lines • Show All 206 Lines • ▼ Show 20 Lines create_libc_unittest(
${target_name} ${target_name}
DEPENDS "${EXPAND_FLAGS_DEPENDS}" DEPENDS "${EXPAND_FLAGS_DEPENDS}"
FLAGS "${EXPAND_FLAGS_FLAGS}" FLAGS "${EXPAND_FLAGS_FLAGS}"
"${EXPAND_FLAGS_UNPARSED_ARGUMENTS}" "${EXPAND_FLAGS_UNPARSED_ARGUMENTS}"
) )
return() return()
endif() endif()
list(POP_FRONT flags flag) list(GET flags 0 flag)
list(REMOVE_AT flags 0)
extract_flag_modifier(${flag} real_flag modifier) extract_flag_modifier(${flag} real_flag modifier)
if(NOT "${modifier}" STREQUAL "NO") if(NOT "${modifier}" STREQUAL "NO")
expand_flags_for_libc_unittest( expand_flags_for_libc_unittest(
${target_name} ${target_name}
"${flags}" "${flags}"
DEPENDS "${EXPAND_FLAGS_DEPENDS}" IGNORE_MARKER DEPENDS "${EXPAND_FLAGS_DEPENDS}" IGNORE_MARKER
FLAGS "${EXPAND_FLAGS_FLAGS}" IGNORE_MARKER FLAGS "${EXPAND_FLAGS_FLAGS}" IGNORE_MARKER
▲ Show 20 Lines • Show All 287 Lines • Show Last 20 Lines