[Dexter] Catch value error when encountering invalid address

[StephenTozer]

Summary

The DexDeclareAddress command checks the value of a variable at a certain point in the debugged program, and saves that value to be used in other commands. If the value at that point is not a valid address however, it currently causes an error in Dexter when we try to cast it - this is fixed in this patch by catching the error and leaving the address value unresolved.

[Orlando]

I've added an inline suggestion but I'm happy with or without that change, LGTM.

cross-project-tests/debuginfo-tests/dexter/dex/command/commands/DexDeclareAddress.py

2–1

Changing the pass here to continue, then dropping the else: may improve readability now that the additional try block is required.

cross-project-tests/debuginfo-tests/dexter/dex/command/commands/DexDeclareAddress.py

 # DExTer : Debugging Experience Tester
 # ~~~~~~   ~         ~~         ~   ~~
 #
 # Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 # See https://llvm.org/LICENSE.txt for license information.
 # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 """Commmand sets the path for all following commands to 'declared_file'.
 """
 
def eval(self, step_collection):
                 os.path.samefile(loc.path, self.path) and
                 loc.lineno == self.on_line):
                 if self.hit_count > 0:
                     self.hit_count -= 1
                     continue
                 try:
                     watch = step.program_state.frames[0].watches[self.expression]
                 except KeyError:
-                    pass
-                else:
+                    continue
+                try:
                     hex_val = int(watch.value, 16)
-                    self.address_resolutions[self.get_address_name()] = hex_val
-                    break
+                except ValueError:
+                    hex_val = None