This is an archive of the discontinued LLVM Phabricator instance.

Differential D127011

[flang] Fix crash in IsSaved()
ClosedPublic

Authored by klausler on Jun 3 2022, 3:39 PM.

Details

Reviewers
vdonaldson
Commits
rG66a871b973c5: [flang] Fix crash in IsSaved()
Summary

Code was accessing ProcEntityDetails in a symbol that didn't have them.

Diff Detail

Event Timeline

klausler created this revision.Jun 3 2022, 3:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2022, 3:39 PM
Herald added a subscriber: jdoerfert. · View Herald Transcript
klausler requested review of this revision.Jun 3 2022, 3:39 PM
vdonaldson accepted this revision.Jun 3 2022, 3:41 PM
This revision is now accepted and ready to land.Jun 3 2022, 3:41 PM
Harbormaster completed remote builds in B167822: Diff 434168.Jun 3 2022, 3:59 PM
Closed by commit rG66a871b973c5: [flang] Fix crash in IsSaved() (authored by klausler). · Explain WhyJun 3 2022, 5:00 PM
This revision was automatically updated to reflect the committed changes.
klausler added a commit: rG66a871b973c5: [flang] Fix crash in IsSaved().

Revision Contents

PathSize
flang/
lib/
Evaluate/
2 lines

Diff 434168

flang/lib/Evaluate/tools.cpp

Context not available.
} else if (const auto *object{symbol.detailsIf<ObjectEntityDetails>()}; } else if (const auto *object{symbol.detailsIf<ObjectEntityDetails>()};
object && object->init()) { object && object->init()) {
return true; return true;
} else if (IsProcedurePointer(symbol) && } else if (IsProcedurePointer(symbol) && symbol.has<ProcEntityDetails>() &&
symbol.get<ProcEntityDetails>().init()) { symbol.get<ProcEntityDetails>().init()) {
return true; return true;
} else if (scope.hasSAVE()) { } else if (scope.hasSAVE()) {
Context not available.