This is an archive of the discontinued LLVM Phabricator instance.

Differential D126951

[Fortran] Don't add -Werror=date-time for flang
ClosedPublic

Authored by rovka on Jun 3 2022, 2:07 AM.

Details

Reviewers
awarzynski
sscalpone
Commits
rT25c31a4e8b54: [Fortran] Don't add -Werror=date-time for flang
Summary

At the moment, flang doesn't support -Werror=date-time, so we
can't run the llvm-test-suite with it. This patch skips adding the flag
if the Fortran compiler is set to flang. It shouldn't affect any other
compiler (and especially not C/C++ ones).

Diff Detail

Repository
rT test-suite

Event Timeline

rovka created this revision.Jun 3 2022, 2:07 AM
Herald added a reviewer: sscalpone. · View Herald TranscriptJun 3 2022, 2:07 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: jdoerfert, mgorny. · View Herald Transcript
rovka requested review of this revision.Jun 3 2022, 2:07 AM
awarzynski accepted this revision.Jun 9 2022, 2:19 AM

Sorry, forgot to submit my reply earlier!

LGTM, thanks!

This revision is now accepted and ready to land.Jun 9 2022, 2:19 AM
Closed by commit rT25c31a4e8b54: [Fortran] Don't add -Werror=date-time for flang (authored by rovka). · Explain WhyJun 10 2022, 2:25 AM
This revision was automatically updated to reflect the committed changes.
rovka added a commit: rT25c31a4e8b54: [Fortran] Don't add -Werror=date-time for flang.

Revision Contents

PathSize
5 lines

Diff 435843

CMakeLists.txt

Show First 20 Lines • Show All 47 Lines • ▼ Show 20 Lines
add_definitions(-DNDEBUG) add_definitions(-DNDEBUG)
option(TEST_SUITE_SUPPRESS_WARNINGS "Suppress all warnings" ON) option(TEST_SUITE_SUPPRESS_WARNINGS "Suppress all warnings" ON)
if(${TEST_SUITE_SUPPRESS_WARNINGS}) if(${TEST_SUITE_SUPPRESS_WARNINGS})
add_definitions(-w) add_definitions(-w)
endif() endif()
# We want reproducible builds, so using __DATE__ and __TIME__ is bad # We want reproducible builds, so using __DATE__ and __TIME__ is bad
# FIXME: Add this unconditionally when flang starts supporting it.
if(NOT CMAKE_Fortran_COMPILER_ID STREQUAL "LLVMFlang")
add_definitions(-Werror=date-time) add_definitions(-Werror=date-time)
endif()
# Add path for custom modules # Add path for custom modules
set(CMAKE_MODULE_PATH set(CMAKE_MODULE_PATH
${CMAKE_MODULE_PATH} ${CMAKE_MODULE_PATH}
"${CMAKE_CURRENT_SOURCE_DIR}/cmake" "${CMAKE_CURRENT_SOURCE_DIR}/cmake"
"${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules" "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules"
) )
▲ Show 20 Lines • Show All 329 Lines • Show Last 20 Lines