This is an archive of the discontinued LLVM Phabricator instance.

[mlir][complex] Sanity check for tan operation in complex dialect
ClosedPublic

Authored by Lewuathe on Jun 2 2022, 12:58 AM.

Details

Summary

Add a sanity check for newly added tan operation in complex dialect. It follows-up to https://reviews.llvm.org/D126685.

Diff Detail

Event Timeline

Lewuathe created this revision.Jun 2 2022, 12:58 AM
Lewuathe requested review of this revision.Jun 2 2022, 12:58 AM
Lewuathe edited the summary of this revision. (Show Details)Jun 2 2022, 12:58 AM

@Lewuathe could you also add an integration test for tanh to correctness.mlir? I don't think that lit tests are particularly useful for convert-to-standard pass.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 2 2022, 1:34 AM
This revision was automatically updated to reflect the committed changes.

Sure, let me work on that.