This is an archive of the discontinued LLVM Phabricator instance.

Differential D126598

Fixed typo in hmaptool CMakeLists.txt
ClosedPublic

Authored by danielh2942 on May 28 2022, 9:30 AM.

Details

Reviewers
keith
Commits
rG50f2e4992456: [clang][cmake] Fixed typo in hmaptool CMakeLists.txt
Summary

There was a typo in the CMakeLists.txt for hmap tool that installed it to the wrong directory

https://github.com/llvm/llvm-project/issues/55753

Diff Detail

Event Timeline

danielh2942 created this revision.May 28 2022, 9:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 28 2022, 9:30 AM
Herald added a subscriber: mgorny. · View Herald Transcript
danielh2942 requested review of this revision.May 28 2022, 9:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 28 2022, 9:30 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
danielh2942 retitled this revision from # Enter a commit message. # # Changes: # # clang/utils/hmaptool/CMakeLists.txt Fixed typo in hmaptool CMakeLists.txt to Fixed typo in hmaptool CMakeLists.txt.May 28 2022, 9:31 AM
danielh2942 edited the summary of this revision. (Show Details)
keith accepted this revision.May 28 2022, 9:52 AM
This revision is now accepted and ready to land.May 28 2022, 9:52 AM
Harbormaster completed remote builds in B166781: Diff 432735.May 28 2022, 10:09 AM
Closed by commit rG50f2e4992456: [clang][cmake] Fixed typo in hmaptool CMakeLists.txt (authored by danielh2942, committed by keith). · Explain WhyMay 28 2022, 10:15 AM
This revision was automatically updated to reflect the committed changes.
keith added a commit: rG50f2e4992456: [clang][cmake] Fixed typo in hmaptool CMakeLists.txt.

Revision Contents

PathSize
clang/
utils/
hmaptool/
2 lines

Diff 432735

clang/utils/hmaptool/CMakeLists.txt

add_custom_command(OUTPUT "${LLVM_TOOLS_BINARY_DIR}/hmaptool" add_custom_command(OUTPUT "${LLVM_TOOLS_BINARY_DIR}/hmaptool"
COMMAND "${CMAKE_COMMAND}" -E copy "${CMAKE_CURRENT_SOURCE_DIR}/hmaptool" "${LLVM_TOOLS_BINARY_DIR}" COMMAND "${CMAKE_COMMAND}" -E copy "${CMAKE_CURRENT_SOURCE_DIR}/hmaptool" "${LLVM_TOOLS_BINARY_DIR}"
DEPENDS "${CMAKE_CURRENT_SOURCE_DIR}/hmaptool") DEPENDS "${CMAKE_CURRENT_SOURCE_DIR}/hmaptool")
install(PROGRAMS hmaptool DESTINATION "${LLVM_UTILS_INSTALL_DIR}}" COMPONENT hmaptool) install(PROGRAMS hmaptool DESTINATION "${LLVM_UTILS_INSTALL_DIR}" COMPONENT hmaptool)
add_custom_target(hmaptool ALL DEPENDS "${LLVM_TOOLS_BINARY_DIR}/hmaptool") add_custom_target(hmaptool ALL DEPENDS "${LLVM_TOOLS_BINARY_DIR}/hmaptool")
set_target_properties(hmaptool PROPERTIES FOLDER "Utils") set_target_properties(hmaptool PROPERTIES FOLDER "Utils")
if(NOT LLVM_ENABLE_IDE) if(NOT LLVM_ENABLE_IDE)
add_llvm_install_targets("install-hmaptool" add_llvm_install_targets("install-hmaptool"
DEPENDS hmaptool DEPENDS hmaptool
COMPONENT hmaptool) COMPONENT hmaptool)
endif() endif()