This is an archive of the discontinued LLVM Phabricator instance.

Differential D126528

[test] Remove an outdated FIXME
ClosedPublic

Authored by JohnTitor on May 27 2022, 3:49 AM.

Details

Reviewers
vitalybuka
kstoimenov
Commits
rG36c1183c787f: [test] Remove an outdated FIXME
Summary

rG6a9c719ee1be4562a9e16f2c71ac3e51ef9c4292 removed the backticks and this FIXME comment is no longer necessary.

Diff Detail

Event Timeline

JohnTitor created this revision.May 27 2022, 3:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 27 2022, 3:49 AM
JohnTitor requested review of this revision.May 27 2022, 3:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 27 2022, 3:49 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
JohnTitor added reviewers: vitalybuka, kstoimenov.May 27 2022, 3:51 AM
Harbormaster completed remote builds in B166616: Diff 432516.May 27 2022, 4:05 AM
kstoimenov accepted this revision.May 31 2022, 12:49 PM
This revision is now accepted and ready to land.May 31 2022, 12:49 PM
Herald added a subscriber: Enna1. · View Herald TranscriptMay 31 2022, 12:49 PM
Closed by commit rG36c1183c787f: [test] Remove an outdated FIXME (authored by JohnTitor). · Explain WhyMay 31 2022, 4:18 PM
This revision was automatically updated to reflect the committed changes.
JohnTitor added a commit: rG36c1183c787f: [test] Remove an outdated FIXME.

Revision Contents

PathSize
compiler-rt/
test/
asan/
TestCases/
1 line

Diff 433221

compiler-rt/test/asan/TestCases/suppressions-library.cpp

// RUN: %clangxx_asan -O0 -DSHARED_LIB %s %fPIC -shared -o %dynamiclib %ld_flags_rpath_so // RUN: %clangxx_asan -O0 -DSHARED_LIB %s %fPIC -shared -o %dynamiclib %ld_flags_rpath_so
// RUN: %clangxx_asan -O0 %s -o %t %ld_flags_rpath_exe // RUN: %clangxx_asan -O0 %s -o %t %ld_flags_rpath_exe
// Check that without suppressions, we catch the issue. // Check that without suppressions, we catch the issue.
// RUN: not %run %t 2>&1 | FileCheck --check-prefix=CHECK-CRASH %s // RUN: not %run %t 2>&1 | FileCheck --check-prefix=CHECK-CRASH %s
// FIXME: Remove usage of backticks around basename below.
// REQUIRES: shell // REQUIRES: shell
// RUN: echo "interceptor_via_lib:"%xdynamiclib_filename > %t.supp // RUN: echo "interceptor_via_lib:"%xdynamiclib_filename > %t.supp
// RUN: %env_asan_opts=suppressions='"%t.supp"' %run %t 2>&1 | FileCheck --check-prefix=CHECK-IGNORE %s // RUN: %env_asan_opts=suppressions='"%t.supp"' %run %t 2>&1 | FileCheck --check-prefix=CHECK-IGNORE %s
// XFAIL: android // XFAIL: android
#include <stdio.h> #include <stdio.h>
Show All 27 Lines