They are added as entrypoint object targets. The header-gen
infrastructure has been extended to enable handling standard required
global objects. The libc-api-test has also been extended to verify the
global object declarations.
Details
- Reviewers
lntue - Commits
- rG9b8ca3c1f18c: [libc] Add global stdout and stderr objects.
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
libc/utils/HdrGen/PublicAPICommand.cpp | ||
---|---|---|
119 | const auto &Name? |
libc/src/__support/File/linux_file.cpp | ||
---|---|---|
169–170 | Yes, fixed! | |
176 | About buffering mode, we do not have line buffering support yet so I just left the value at 0. I have added a TODO to update that when we add line buffering support. About WRITE vs APPEND, My intention was to put APPEND on both but I was playing with WRITE on one of them but forgot to put it back to APPEND. I have updated both to APPEND now. Overall, this is a total case of copy-paste oversight. Sorry about that. |
These should probably be static