This is an archive of the discontinued LLVM Phabricator instance.

Differential D126214

Register profiling support for OrcJit in lli
ClosedPublic

Authored by tetzank on May 23 2022, 9:04 AM.

Details

Reviewers
lhames
Commits
rGb6ae90b86c42: [lli] Register profiling support for ORC in lli
Summary

The registration of the event listeners was just missing for OrcJit,
only enabled for MCJit.

Fixes #55528

Diff Detail

Unit TestsFailed

TimeTest
60,050 msx64 debian > libFuzzer.libFuzzer::fuzzer-leak.test
60,050 msx64 debian > libFuzzer.libFuzzer::value-profile-load.test

Event Timeline

tetzank created this revision.May 23 2022, 9:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2022, 9:04 AM
tetzank requested review of this revision.May 23 2022, 9:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2022, 9:04 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
tetzank added a reviewer: lhames.May 23 2022, 9:07 AM
Herald added a subscriber: StephenFan. · View Herald TranscriptMay 23 2022, 9:07 AM
Harbormaster completed remote builds in B165857: Diff 431395.May 23 2022, 9:48 AM
lhames accepted this revision.May 24 2022, 6:33 PM

LGTM. Thanks very much Frank!

If you have commit access please go ahead and commit. If you don't have commit access please just let me know the name and email that you would like me to use for attribution and I can commit the patch on your behalf.

This revision is now accepted and ready to land.May 24 2022, 6:33 PM
tetzank added a comment.May 25 2022, 5:55 AM
In D126214#3536023, @lhames wrote:

If you have commit access please go ahead and commit. If you don't have commit access please just let me know the name and email that you would like me to use for attribution and I can commit the patch on your behalf.

I do not have commit access. Please commit as Frank Tetzel <frank.tetzel@sap.com>. Thank you for your guidance.

This revision was landed with ongoing or failed builds.Mar 14 2023, 5:03 PM
Closed by commit rGb6ae90b86c42: [lli] Register profiling support for ORC in lli (authored by tetzank, committed by lhames). · Explain Why
This revision was automatically updated to reflect the committed changes.
lhames added a commit: rGb6ae90b86c42: [lli] Register profiling support for ORC in lli.
lhames added a comment.Mar 14 2023, 5:03 PM

Very belatedly landed. Thanks again for this Frank!

Revision Contents

PathSize
llvm/
tools/
lli/
15 lines

Diff 431395

llvm/tools/lli/lli.cpp

Show First 20 Lines • Show All 938 Lines • ▼ Show 20 Lines Builder.setObjectLinkingLayerCreator([&EPC](orc::ExecutionSession &ES,
ES, ExitOnErr(orc::createJITLoaderGDBRegistrar(ES)))); ES, ExitOnErr(orc::createJITLoaderGDBRegistrar(ES))));
return L; return L;
}); });
} }
auto J = ExitOnErr(Builder.create()); auto J = ExitOnErr(Builder.create());
auto *ObjLayer = &J->getObjLinkingLayer(); auto *ObjLayer = &J->getObjLinkingLayer();
if (auto *RTDyldObjLayer = dyn_cast<orc::RTDyldObjectLinkingLayer>(ObjLayer)) if (auto *RTDyldObjLayer = dyn_cast<orc::RTDyldObjectLinkingLayer>(ObjLayer)) {
RTDyldObjLayer->registerJITEventListener( RTDyldObjLayer->registerJITEventListener(
*JITEventListener::createGDBRegistrationListener()); *JITEventListener::createGDBRegistrationListener());
#if LLVM_USE_OPROFILE
RTDyldObjLayer->registerJITEventListener(
*JITEventListener::createOProfileJITEventListener());
#endif
#if LLVM_USE_INTEL_JITEVENTS
RTDyldObjLayer->registerJITEventListener(
*JITEventListener::createIntelJITEventListener());
#endif
#if LLVM_USE_PERF
RTDyldObjLayer->registerJITEventListener(
*JITEventListener::createPerfJITEventListener());
#endif
}
if (PerModuleLazy) if (PerModuleLazy)
J->setPartitionFunction(orc::CompileOnDemandLayer::compileWholeModule); J->setPartitionFunction(orc::CompileOnDemandLayer::compileWholeModule);
auto Dump = createDebugDumper(); auto Dump = createDebugDumper();
J->getIRTransformLayer().setTransform( J->getIRTransformLayer().setTransform(
[&](orc::ThreadSafeModule TSM, [&](orc::ThreadSafeModule TSM,
▲ Show 20 Lines • Show All 196 Lines • Show Last 20 Lines