This is an archive of the discontinued LLVM Phabricator instance.

Differential D126191

[Clang][CodeGen] Fix the cmse-clear-return.c test.
ClosedPublic

Authored by kosarev on May 23 2022, 3:59 AM.

Details

Reviewers
fhahn
nikic
Commits
rGbe4eaf10eef7: [Clang][CodeGen] Fix the cmse-clear-return.c test.
Summary

Caught with D125604.

Diff Detail

Event Timeline

kosarev created this revision.May 23 2022, 3:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2022, 3:59 AM
kosarev requested review of this revision.May 23 2022, 3:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2022, 3:59 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
kosarev added reviewers: fhahn, nikic.May 23 2022, 4:00 AM
Harbormaster completed remote builds in B165804: Diff 431323.May 23 2022, 4:35 AM
nikic accepted this revision.May 23 2022, 5:29 AM

Not familiar with this test, but the change looks reasonable.

This revision is now accepted and ready to land.May 23 2022, 5:29 AM
Closed by commit rGbe4eaf10eef7: [Clang][CodeGen] Fix the cmse-clear-return.c test. (authored by kosarev). · Explain WhyMay 24 2022, 4:50 AM
This revision was automatically updated to reflect the committed changes.
kosarev added a commit: rGbe4eaf10eef7: [Clang][CodeGen] Fix the cmse-clear-return.c test..

Revision Contents

PathSize
clang/
test/
CodeGen/
11 lines

Diff 431323

clang/test/CodeGen/cmse-clear-return.c

Show First 20 Lines • Show All 222 Lines • ▼ Show 20 Lines
typedef struct __attribute__((packed)) T14 { typedef struct __attribute__((packed)) T14 {
short a; short a;
short b; short b;
} T14; } T14;
T14 t14; T14 t14;
__attribute__((cmse_nonsecure_entry)) T14 f14(void) { return t14; } __attribute__((cmse_nonsecure_entry)) T14 f14(void) { return t14; }
// CHECK: define {{.*}} @f14() // CHECK: define {{.*}} @f14()
// CHECK: [[R:%.*]] = load // CHECK: [[R:%.*]] = load
// CHECK-LE-NOPT-NEXT: [[AND:%.+]] = and i32 [[R]], -1 // CHECK-LE-OPT: ret i32 [[R]]
// CHECK-BE-NOPT-NEXT: [[AND:%.+]] = and i32 [[R]], -1 // CHECK-LE-NOPT: [[AND:%.+]] = and i32 [[R]], -1
// CHECK_NEXT: ret i32 [[AND]] // CHECK-LE-NOPT: ret i32 [[AND]]
// CHECK-BE-OPT: ret i32 [[R]]
// LE: 1111..11 1111..11 11111111 11111111 0xfffff3f3/-3085 // LE: 1111..11 1111..11 11111111 11111111 0xfffff3f3/-3085
// BE: 11..1111 11..1111 11111111 11111111 0xcfcfffff/-808452097 // BE: 11..1111 11..1111 11111111 11111111 0xcfcfffff/-808452097
typedef struct T17 { typedef struct T17 {
struct T170 { struct T170 {
char a : 2; char a : 2;
char : 2, b : 4; char : 2, b : 4;
} a[2]; } a[2];
Show All 24 Lines