This is an archive of the discontinued LLVM Phabricator instance.

[libc] Fix builds for libc-integration-tests and libc-loader-tests
AbandonedPublic

Authored by cratonica on May 20 2022, 1:25 PM.

Details

Reviewers
sivachandra
Summary

These were failing due to unresolved references to errno

Diff Detail

Event Timeline

cratonica created this revision.May 20 2022, 1:25 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 20 2022, 1:25 PM
cratonica requested review of this revision.May 20 2022, 1:25 PM
cratonica updated this revision to Diff 431040.

Missed the linker change to aarch64

Seems like this is the wrong place to add these deps. Can you share what you are trying to run and what error you are seeing? FWIW, the integrations tests for x86_64 and aarch64 are run on the public CI builders and they have not caught any problem so far. For example https://lab.llvm.org/buildbot/#/builders/163/builds/18187 and https://lab.llvm.org/buildbot/#/builders/223/builds/945. Neither am I seeing any problems with a clean build.

cratonica abandoned this revision.May 20 2022, 1:58 PM

Yes, you are right -- the error I was seeing was a result of not running ninja llvmlibc prior to ninja libc-integration-tests on a clean build.

I will drop this.