This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Fix spurious lldb_assert in PrintCommandOutput
ClosedPublic

Authored by JDevlieghere on May 20 2022, 11:46 AM.

Details

Summary

When the string passed to PrintCommandOutput doesn't end with a newline, written will exceed size and result in an lldbassert. After 8e776bb660dda6c51ce7ca6cea641db1f47aa9cf we don't really need written anymore and we can check whether str is empty instead.

Diff Detail

Event Timeline

JDevlieghere created this revision.May 20 2022, 11:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 20 2022, 11:46 AM
JDevlieghere requested review of this revision.May 20 2022, 11:46 AM
mib accepted this revision.May 20 2022, 2:02 PM
This revision is now accepted and ready to land.May 20 2022, 2:02 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 20 2022, 2:15 PM