This is an archive of the discontinued LLVM Phabricator instance.

[clang] Don't parse MS attributes in `ParseExportDeclaration()`.
ClosedPublic

Authored by mboehme on May 20 2022, 5:05 AM.

Details

Summary

As @rsmith commented on https://reviews.llvm.org/D111548: "That looks like it's
simply a bug as far as I can tell, and that call can be removed. MS attributes
will be parsed as part of the decl specifier sequence as needed and don't need
to be parsed as declaration attributes."

Diff Detail

Event Timeline

mboehme created this revision.May 20 2022, 5:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 20 2022, 5:05 AM
mboehme requested review of this revision.May 20 2022, 5:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 20 2022, 5:05 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aaron.ballman accepted this revision.May 24 2022, 7:02 AM

LGTM -- I checked as well and these changes are NFC. Thanks!

This revision is now accepted and ready to land.May 24 2022, 7:02 AM