This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Remove the legacy LIBCXX_LIBCPPABI_VERSION option
ClosedPublic

Authored by ldionne on May 16 2022, 7:06 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGefcee4b06d2f: [libc++] Remove the legacy LIBCXX_LIBCPPABI_VERSION option
Summary

I think this notion of libc++abi's version was relevant a long time ago
on Apple platforms when we were using a Xcode project to build the library.
As part of moving Apple's build to CMake, D59489 made it possible to
specify the "ABI version" of libc++abi in use. However, it's not possible
to build libc++abi with that old ABI anymore and we don't need the ability
to link against that version from libc++ anymore.

Hence, we can clean this up and stop falsely pretending that libc++abi
has more than one ABI version.

Diff Detail

Event Timeline

ldionne created this revision.May 16 2022, 7:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2022, 7:06 AM
Herald added a subscriber: mgorny. · View Herald Transcript
ldionne requested review of this revision.May 16 2022, 7:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2022, 7:06 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.May 16 2022, 12:23 PM
This revision is now accepted and ready to land.May 16 2022, 12:23 PM
libcxx/CMakeLists.txt