Page MenuHomePhabricator

[compiler-rt] Add missing NO_EXEC_STACK_DIRECTIVE to tsan_rtl_s390x.S
ClosedPublic

Authored by tbaeder on May 12 2022, 1:53 AM.

Details

Summary

The libclang_rt.tsan-s390x.so otherwise requires an executable stack.

Diff Detail

Unit TestsFailed

TimeTest
880 msx64 debian > SanitizerCommon-tsan-x86_64-Linux.Linux::decorate_proc_maps.cpp
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -gline-tables-only -fsanitize=thread -m64 -funwind-tables -ldl -g /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/sanitizer_common/TestCases/Linux/decorate_proc_maps.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/sanitizer_common/tsan-x86_64-Linux/Linux/Output/decorate_proc_maps.cpp.tmp

Event Timeline

tbaeder created this revision.May 12 2022, 1:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 12 2022, 1:53 AM
Herald added a subscriber: dberris. · View Herald Transcript
tbaeder requested review of this revision.May 12 2022, 1:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 12 2022, 1:53 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
iii accepted this revision.May 12 2022, 5:03 AM

Thanks for catching this! LGTM.

This revision is now accepted and ready to land.May 12 2022, 5:03 AM

Sorry, I'm not familiar enough with compiler-rt tests. Is the failing Linux/decorate_proc_maps test my fault?

iii added a comment.May 12 2022, 3:18 PM

I don't think so. First of all, this is on another architecture; and then I tried running this test on both x86_64 and s390x with your change, and it succeeded in both cases for me.

Looking at the test, I don't see any good reason for it to exit without producing any output.
The only thing is that there is no error checking for pthread_create(), pthread_join(), open(), write() and close() - maybe the test hit some of the ulimits and one of these failed?

This revision was landed with ongoing or failed builds.May 12 2022, 11:05 PM
This revision was automatically updated to reflect the committed changes.