This is an archive of the discontinued LLVM Phabricator instance.

Do not include default sanitizer blacklists into -M/-MM/-MD/-MMD output.
ClosedPublic

Authored by krasin on Sep 1 2015, 3:58 PM.

Details

Summary

Do not include default sanitizer blacklists into -M/-MM/-MD/-MMD output.

Introduce a frontend option -fdepfile-entry, and only insert them
for the user-defined sanitizer blacklists. In frontend, grab ExtraDeps
from -fdepfile-entry, instead of -fsanitize-blacklist.

Diff Detail

Event Timeline

krasin updated this revision to Diff 33747.Sep 1 2015, 3:58 PM
krasin retitled this revision from to Do not include default sanitizer blacklists into -M/-MM/-MD/-MMD output..
krasin updated this object.
krasin added reviewers: pcc, rsmith.
krasin added a subscriber: cfe-commits.
pcc edited edge metadata.Sep 1 2015, 4:09 PM

It's probably time to add something like the driver test I was talking about in D12021. Without that, you will have no test coverage for the functional change here.

krasin updated this revision to Diff 33764.Sep 1 2015, 5:14 PM
krasin edited edge metadata.

Add a test for default blacklist.

krasin added a comment.Sep 1 2015, 5:15 PM
In D12544#237819, @pcc wrote:

It's probably time to add something like the driver test I was talking about in D12021. Without that, you will have no test coverage for the functional change here.

Done, please, take a look.

pcc accepted this revision.Sep 1 2015, 8:32 PM
pcc edited edge metadata.

LGTM with nit.

test/Driver/fsanitize-blacklist.c
25

Maybe use FileCheck -implicit-check-not= to verify that this doesn't also appear on the other side of the -fsanitize-blacklist?

This revision is now accepted and ready to land.Sep 1 2015, 8:32 PM
krasin updated this revision to Diff 33849.Sep 2 2015, 1:02 PM
krasin edited edge metadata.

Addressed a nit.

test/Driver/fsanitize-blacklist.c
26

Good idea. Done.

krasin closed this revision.Sep 2 2015, 1:03 PM