This is an archive of the discontinued LLVM Phabricator instance.

Differential D125105

[flang] Operands of SIGN() need not have same kind
ClosedPublic

Authored by klausler on May 6 2022, 10:16 AM.

Details

Reviewers
PeteSteinfeld
Commits
rG18dd123c5675: [flang] Operands of SIGN() need not have same kind
Summary

The standard requires that the operands of the intrinsic function
SIGN() must have the same type (INTEGER or REAL), but they are not
required to have the same kind.

Diff Detail

Event Timeline

klausler created this revision.May 6 2022, 10:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2022, 10:16 AM
Herald added a subscriber: jdoerfert. · View Herald Transcript
klausler requested review of this revision.May 6 2022, 10:16 AM
PeteSteinfeld accepted this revision.May 6 2022, 10:34 AM

All builds and tests correctly and looks good.

This revision is now accepted and ready to land.May 6 2022, 10:34 AM
Harbormaster completed remote builds in B163172: Diff 427669.May 6 2022, 11:12 AM
Closed by commit rG18dd123c5675: [flang] Operands of SIGN() need not have same kind (authored by klausler). · Explain WhyMay 9 2022, 2:39 PM
This revision was automatically updated to reflect the committed changes.
klausler added a commit: rG18dd123c5675: [flang] Operands of SIGN() need not have same kind.

Revision Contents

PathSize
flang/
lib/
Evaluate/
3 lines
test/
Evaluate/
8 lines

Diff 427669

flang/lib/Evaluate/intrinsics.cpp

Context not available.
{"shifta", {{"i", SameInt}, {"shift", AnyInt}}, SameInt}, {"shifta", {{"i", SameInt}, {"shift", AnyInt}}, SameInt},
{"shiftl", {{"i", SameInt}, {"shift", AnyInt}}, SameInt}, {"shiftl", {{"i", SameInt}, {"shift", AnyInt}}, SameInt},
{"shiftr", {{"i", SameInt}, {"shift", AnyInt}}, SameInt}, {"shiftr", {{"i", SameInt}, {"shift", AnyInt}}, SameInt},
{"sign", {{"a", SameIntOrReal}, {"b", SameIntOrReal}}, SameIntOrReal}, {"sign", {{"a", SameInt}, {"b", AnyInt}}, SameInt},
{"sign", {{"a", SameReal}, {"b", AnyReal}}, SameReal},
{"sin", {{"x", SameFloating}}, SameFloating}, {"sin", {{"x", SameFloating}}, SameFloating},
{"sind", {{"x", SameFloating}}, SameFloating}, {"sind", {{"x", SameFloating}}, SameFloating},
{"sinh", {{"x", SameFloating}}, SameFloating}, {"sinh", {{"x", SameFloating}}, SameFloating},
Context not available.

flang/test/Evaluate/folding02.f90

Context not available.
! Expected values come from libpgmath-precise for Real(4) and Real(8) and ! Expected values come from libpgmath-precise for Real(4) and Real(8) and
! were computed on X86_64. ! were computed on X86_64.
logical, parameter :: test_sign_i4 = sign(1_4,2_4) == 1_4 .and. sign(1_4,-3_4) == -1_4 logical, parameter :: test_sign_i4 = sign(1_4,2) == 1_4 .and. sign(1_4,-3_8) == -1_4
logical, parameter :: test_sign_i8 = sign(1_8,2_8) == 1_8 .and. sign(1_8,-3_8) == -1_8 logical, parameter :: test_sign_i8 = sign(1_8,2) == 1_8 .and. sign(1_8,-3_8) == -1_8
! Real scalar intrinsic function tests ! Real scalar intrinsic function tests
#define TEST_FLOATING(name, result, expected, t, k) \ #define TEST_FLOATING(name, result, expected, t, k) \
Context not available.
TEST_R4(log_gamma, log_gamma(3.5_4), 1.20097362995147705078125_4) TEST_R4(log_gamma, log_gamma(3.5_4), 1.20097362995147705078125_4)
TEST_R4(mod, mod(-8.1_4, 5._4), (-3.1000003814697265625_4)) TEST_R4(mod, mod(-8.1_4, 5._4), (-3.1000003814697265625_4))
TEST_R4(real, real(z'3f800000'), 1._4) TEST_R4(real, real(z'3f800000'), 1._4)
logical, parameter :: test_sign_r4 = sign(1._4,2._4) == 1._4 .and. sign(1._4,-2._4) == -1._4 logical, parameter :: test_sign_r4 = sign(1._4,2._8) == 1._4 .and. sign(1._4,-2._4) == -1._4
TEST_R4(sin, sin(1.6_4), 0.99957358837127685546875_4) TEST_R4(sin, sin(1.6_4), 0.99957358837127685546875_4)
TEST_R4(sinh, sinh(0.9_4), 1.0265166759490966796875_4) TEST_R4(sinh, sinh(0.9_4), 1.0265166759490966796875_4)
TEST_R4(sqrt, sqrt(1.1_4), 1.0488088130950927734375_4) TEST_R4(sqrt, sqrt(1.1_4), 1.0488088130950927734375_4)
Context not available.
TEST_R8(mod, mod(-8.1_8, 5._8), & TEST_R8(mod, mod(-8.1_8, 5._8), &
(-3.0999999999999996447286321199499070644378662109375_8)) (-3.0999999999999996447286321199499070644378662109375_8))
TEST_R8(real, real(z'3ff0000000000000',8), 1._8) TEST_R8(real, real(z'3ff0000000000000',8), 1._8)
logical, parameter :: test_sign_r8 = sign(1._8,2._8) == 1._8 .and. sign(1._8,-2._8) == -1._8 logical, parameter :: test_sign_r8 = sign(1._8,2._8) == 1._8 .and. sign(1._8,-2._4) == -1._8
TEST_R8(sin, sin(1.6_8), & TEST_R8(sin, sin(1.6_8), &
0.99957360304150510987852840116829611361026763916015625_8) 0.99957360304150510987852840116829611361026763916015625_8)
TEST_R8(sinh, sinh(0.9_8), & TEST_R8(sinh, sinh(0.9_8), &
Context not available.