This is an archive of the discontinued LLVM Phabricator instance.

[Bazel] Add support for s390x build target
ClosedPublic

Authored by vibhutisawant on May 6 2022, 7:59 AM.

Details

Summary

While executing the test suite for Tensorflow(v2.8.0), we encountered multiple TC failures with the below error

'z14' is not a recognized processor for this target

This patch adds the s390x target to the build target list. It fixes TC failures in multiple modules of Tensorflow on s390x arch. It is also tested to have no effect on x86 machines.

Diff Detail

Event Timeline

vibhutisawant created this revision.May 6 2022, 7:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2022, 7:59 AM
Herald added a subscriber: pengfei. · View Herald Transcript
vibhutisawant requested review of this revision.May 6 2022, 7:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2022, 7:59 AM
GMNGeoffrey accepted this revision.May 10 2022, 5:32 PM
GMNGeoffrey added a subscriber: GMNGeoffrey.

Let me know if you need me to land this for you (see https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access)

This revision is now accepted and ready to land.May 10 2022, 5:32 PM

Yes, could you please commit the same? Author details are "Vibhuti Sawant <Vibhuti.Sawant@ibm.com>". Thanks.

Recreating the patch with appropriate metadata

However you created this patch, it's causing me issues when trying to arc patch it. It looks like it's missing a lot of a metadata (in particular, a base revision). I've manually recreated the revision and reuploaded it here, but FYI for future reference

This revision was automatically updated to reflect the committed changes.

Hi @GMNGeoffrey sorry for the trouble, I uploaded the patch using GUI, and possibly something might have been missed. Will take care next time. Thanks :)

Hi @GMNGeoffrey sorry for the trouble, I uploaded the patch using GUI, and possibly something might have been missed. Will take care next time. Thanks :)

No worries :-) Just a heads up. I don't understand phab well enough to say what the actual issue is, but I think it's a common problem with the web UI that you might end up with a patch with less metadata. One thing you can do that's helpful if still using the web UI is to generate your patches with full context so people can still see the surrounding code. I think in this case you also didn't set the repository field either. Not sure if either of those would've helped with the base revision thing though.

Noted ✔️
Yes right, I think I missed setting the repository field. Will make sure to follow above points before I submit a patch. Thanks once again! :)