This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][AVR] Fix avr_SOURCES CMake variable
ClosedPublic

Authored by aykevl on May 4 2022, 3:54 PM.

Details

Summary

D123200 did not include the generic sources, which means that only the AVR-specific sources were compiled. With this change, generic sources are included as expected.

Tested with the following commands:

cmake -G Ninja -DCOMPILER_RT_DEFAULT_TARGET_TRIPLE=avr -DCOMPILER_RT_BAREMETAL_BUILD=1 -DCMAKE_C_COMPILER=clang-14 -DCMAKE_C_FLAGS="--target=avr -mmcu=avr5 -nostdlibinc -mdouble=64" ../path/to/builtins
ninja

Diff Detail

Event Timeline

aykevl created this revision.May 4 2022, 3:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2022, 3:54 PM
aykevl requested review of this revision.May 4 2022, 3:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2022, 3:54 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
MaskRay accepted this revision.May 4 2022, 4:36 PM

LGTM.

This revision is now accepted and ready to land.May 4 2022, 4:36 PM
This revision was automatically updated to reflect the committed changes.