This is an archive of the discontinued LLVM Phabricator instance.

[libunwind] Silence warnings about unused variables. NFC.
ClosedPublic

Authored by mstorsjo on May 4 2022, 2:59 AM.

Details

Reviewers
MaskRay
Group Reviewers
Restricted Project
Commits
rG6123e9c0d03b: [libunwind] Silence warnings about unused variables. NFC.
Summary

This variable was considered unused if building with log messages
disabled, when building for Windows with Dwarf exception handling
(i.e. for i386).

Diff Detail

Event Timeline

mstorsjo created this revision.May 4 2022, 2:59 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 4 2022, 2:59 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: StephenFan. · View Herald Transcript
mstorsjo requested review of this revision.May 4 2022, 2:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2022, 2:59 AM
MaskRay accepted this revision.May 4 2022, 9:37 AM

Looks great!

if building with log messages disabled

Perhaps specify the preciser condition: when NDEBUG is defined

This revision is now accepted and ready to land.May 4 2022, 9:37 AM