This is an archive of the discontinued LLVM Phabricator instance.

[libc++][NFC] Replace _LIBCPP_INLINE_VISIBILTIY and _VSTD in <string>
ClosedPublic

Authored by philnik on Apr 29 2022, 2:19 AM.

Details

Summary

Replace all the instances of _LIBCPP_INLINE_VISIBILITY with _LIBCPP_HIDE_FROM_ABI and _VSTD with std.

Diff Detail

Event Timeline

philnik created this revision.Apr 29 2022, 2:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2022, 2:19 AM
philnik requested review of this revision.Apr 29 2022, 2:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2022, 2:19 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante requested changes to this revision.Apr 29 2022, 8:31 AM

I agree now is a good time to do these changes, thanks!
SGTM, but before approving I like to see MSAN CI green. I expect it's not your bug since main seems to fail in the same way.

I've marked it as needs work since I expect you need to do a rebase.

This revision now requires changes to proceed.Apr 29 2022, 8:31 AM
philnik updated this revision to Diff 426223.Apr 30 2022, 6:22 AM

Rebase again

Mordante accepted this revision.Apr 30 2022, 9:34 AM

LGTM, the AIX CI seems to fail quite often on that ranges test. (Louis has a patch to increment the timeout.)

This revision is now accepted and ready to land.Apr 30 2022, 9:34 AM
This revision was landed with ongoing or failed builds.May 1 2022, 4:00 AM
This revision was automatically updated to reflect the committed changes.