This is an archive of the discontinued LLVM Phabricator instance.

Differential D124280

[git-clang-format] Change run line from python to python3
ClosedPublic

Authored by thakis on Apr 22 2022, 10:46 AM.

Details

Reviewers
MyDeveloperDay
curdeius
Commits
rGc94a02e0e223: [git-clang-format] Change run line from python to python3
Summary

Several systems no longer ship python.

Diff Detail

Event Timeline

thakis created this revision.Apr 22 2022, 10:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2022, 10:46 AM
thakis requested review of this revision.Apr 22 2022, 10:46 AM
thakis added a reviewer: curdeius.
curdeius accepted this revision.Apr 22 2022, 12:01 PM

LGTM. Especially that we already use python3 in clang-format-diff and other scripts, and it's used in many places in LLVM.

This revision is now accepted and ready to land.Apr 22 2022, 12:01 PM
This revision was landed with ongoing or failed builds.Apr 22 2022, 12:15 PM
Closed by commit rGc94a02e0e223: [git-clang-format] Change run line from python to python3 (authored by thakis). · Explain Why
This revision was automatically updated to reflect the committed changes.
thakis added a commit: rGc94a02e0e223: [git-clang-format] Change run line from python to python3.
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2022, 12:15 PM
Harbormaster completed remote builds in B160899: Diff 424533.Apr 22 2022, 1:55 PM

Revision Contents

PathSize
clang/
tools/
clang-format/
2 lines

Diff 424533

clang/tools/clang-format/git-clang-format

#!/usr/bin/env python #!/usr/bin/env python3
# #
#===- git-clang-format - ClangFormat Git Integration ---------*- python -*--===# #===- git-clang-format - ClangFormat Git Integration ---------*- python -*--===#
# #
# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. # Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
# See https://llvm.org/LICENSE.txt for license information. # See https://llvm.org/LICENSE.txt for license information.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
# #
#===------------------------------------------------------------------------===# #===------------------------------------------------------------------------===#
▲ Show 20 Lines • Show All 622 Lines • Show Last 20 Lines