This is an archive of the discontinued LLVM Phabricator instance.

[libc++][CI] added XFAIL LIBCXX-AIX-FIXME to new runnning test cases after install locale on AIX OS.
ClosedPublic

Authored by DiggerLin on Apr 21 2022, 7:19 AM.

Details

Summary
  1. there are 23 test cases which do not run because of locale fileset not install, after the locale installed, these test cases will be run and fail. "LIBCXX-AIX-FIXME" on the 23 test cases which remain to be investigated on AIX.

2.after installed the locale fileset ,
the test case
libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp pass

remove XFAIL: LIBCXX-AIX-FIXME from the file.

Diff Detail

Event Timeline

DiggerLin created this revision.Apr 21 2022, 7:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2022, 7:19 AM
DiggerLin requested review of this revision.Apr 21 2022, 7:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2022, 7:19 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
daltenty accepted this revision.Apr 21 2022, 7:31 AM

LGTM, thanks!

Mordante accepted this revision.Apr 21 2022, 8:45 AM
Mordante added a subscriber: Mordante.

Thanks, LGTM! Please verify this fixes the build before landing.

This revision is now accepted and ready to land.Apr 21 2022, 8:45 AM
DiggerLin updated this revision to Diff 424234.Apr 21 2022, 9:31 AM
DiggerLin retitled this revision from [libc++][CI] remove XFAIL: LIBCXX-AIX-FIXME for compare.pass.cpp to [libc++][CI] added XFAIL LIBCXX-AIX-FIXME to new runnning test cases after install locale on AIX OS..
DiggerLin edited the summary of this revision. (Show Details)

added " XFAIL LIBCXX-AIX-FIXME " to new runnning test cases after install locale on AIX OS

Mordante accepted this revision.Apr 21 2022, 10:36 AM

Still LGTM once the CI is happy.

This revision was landed with ongoing or failed builds.Apr 21 2022, 12:26 PM
This revision was automatically updated to reflect the committed changes.