This is an archive of the discontinued LLVM Phabricator instance.

[LLDB][NativePDB] Fix the case when S_DEFRANGE_SUBFIELD_REGISTERs are out of order.
ClosedPublic

Authored by zequanwu on Apr 19 2022, 8:15 PM.

Details

Summary

Previously, I was assuming that S_DEFRANGE_SUBFIELD_REGISTERs are always in the
increasing order of offset_in_parent until I saw a counter example.

Using std::map so that they are sorted by offset_in_parent.

Diff Detail

Event Timeline

zequanwu created this revision.Apr 19 2022, 8:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2022, 8:15 PM
zequanwu requested review of this revision.Apr 19 2022, 8:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2022, 8:15 PM
labath accepted this revision.Apr 20 2022, 2:13 AM

seems reasonable

lldb/test/Shell/SymbolFile/NativePDB/local-variables-registers.s
247–250

Maybe add a comment about the order being deliberatele inverted.

This revision is now accepted and ready to land.Apr 20 2022, 2:13 AM
zequanwu marked an inline comment as done.Apr 20 2022, 10:33 AM