This is an archive of the discontinued LLVM Phabricator instance.

Look through calls to std::addressof to compute pointer alignment.
ClosedPublic

Authored by efriedma on Apr 18 2022, 10:31 AM.

Details

Summary

This is sort of a followup to D37310; that basically fixed the same issue, but then the libstdc++ implementation of <atomic> changed. Re-fix the the issue in essentially the same way: look through the addressof operation to find the alignment of the underlying object.

Fixes https://github.com/llvm/llvm-project/issues/54963 . Alternative to D123642.

Diff Detail

Event Timeline

efriedma created this revision.Apr 18 2022, 10:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2022, 10:31 AM
efriedma requested review of this revision.Apr 18 2022, 10:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2022, 10:31 AM
This revision is now accepted and ready to land.Apr 18 2022, 11:02 AM
This revision was landed with ongoing or failed builds.Apr 20 2022, 11:30 AM
This revision was automatically updated to reflect the committed changes.