This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Enable move semantics for vector in C++03
ClosedPublic

Authored by philnik on Apr 14 2022, 9:28 AM.

Details

Reviewers
ldionne
Mordante
Group Reviewers
Restricted Project
Commits
rG06cf0ce90a8f: [libc++] Enable move semantics for vector in C++03
Summary

We require move semantics in C++03 anyways, so let's enable them for the containers.

Diff Detail

Event Timeline

philnik created this revision.Apr 14 2022, 9:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 14 2022, 9:28 AM
philnik requested review of this revision.Apr 14 2022, 9:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 14 2022, 9:28 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne requested changes to this revision.Apr 25 2022, 1:55 PM

I am fine with this in principle, but I'd like to see CI green. Please ping me again once that's passing.

libcxx/test/std/containers/sequences/vector/vector.modifiers/resize_not_move_insertable.fail.cpp
9

These all should be: // UNSUPPORTED: c++03 && !stdlib=libc++. Other standard libraries probably don't support move semantics in C++03.

This revision now requires changes to proceed.Apr 25 2022, 1:55 PM
philnik updated this revision to Diff 425990.Apr 29 2022, 2:02 AM
philnik marked an inline comment as done.
  • Try to fix CI
philnik updated this revision to Diff 426362.May 2 2022, 2:39 AM
  • Next try
ldionne accepted this revision.May 18 2022, 12:54 PM

LGTM once my comment is addressed!

libcxx/test/std/containers/sequences/vector/vector.modifiers/resize_not_move_insertable.fail.cpp
9

I don't think this comment was addressed.

This revision is now accepted and ready to land.May 18 2022, 12:54 PM
philnik updated this revision to Diff 430633.May 19 2022, 3:47 AM
philnik marked an inline comment as done.
  • Add //UNSUPPORTED: c++03 && !stdlib=libc++
This revision was automatically updated to reflect the committed changes.