This is an archive of the discontinued LLVM Phabricator instance.

Differential D123724

[flang] Accept TYPE(intrinsic type) in declarations only for non-extension type
ClosedPublic

Authored by klausler on Apr 13 2022, 1:08 PM.

Details

Reviewers
jeanPerier
Commits
rG2503f286486c: [flang] Accept TYPE(intrinsic type) in declarations only for non-extension type
Summary

To avoid clashing with names of user derived types, the redundant
syntax TYPE(intrinsic type spec) must be interpreted as a monomorphic
derived type when "intrinsic type spec" is a single word. This
affects TYPE(BYTE) and TYPE(DOUBLECOMPLEX), but not TYPE(DOUBLE COMPLEX)
in free form source.

Diff Detail

Event Timeline

klausler created this revision.Apr 13 2022, 1:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2022, 1:08 PM
Herald added a subscriber: jdoerfert. · View Herald Transcript
klausler requested review of this revision.Apr 13 2022, 1:08 PM
Harbormaster completed remote builds in B159528: Diff 422625.Apr 13 2022, 1:52 PM
jeanPerier accepted this revision.Apr 14 2022, 5:35 AM

Looks good

This revision is now accepted and ready to land.Apr 14 2022, 5:35 AM
Closed by commit rG2503f286486c: [flang] Accept TYPE(intrinsic type) in declarations only for non-extension type (authored by klausler). · Explain WhyApr 14 2022, 6:19 PM
This revision was automatically updated to reflect the committed changes.
klausler added a commit: rG2503f286486c: [flang] Accept TYPE(intrinsic type) in declarations only for non-extension type.

Revision Contents

PathSize
flang/
docs/
5 lines
lib/
Parser/
7 lines

Diff 422625

flang/docs/Extensions.md

Context not available.
* `$` and `@` as legal characters in names * `$` and `@` as legal characters in names
* Initialization in type declaration statements using `/values/` * Initialization in type declaration statements using `/values/`
* Kind specification with `*`, e.g. `REAL*4` * Kind specification with `*`, e.g. `REAL*4`
* `DOUBLE COMPLEX` * `DOUBLE COMPLEX` as a synonym for `COMPLEX(KIND(0.D0))` --
but not when spelled `TYPE(DOUBLECOMPLEX)`.
* Signed complex literal constants * Signed complex literal constants
* DEC `STRUCTURE`, `RECORD`, with '%FILL'; but `UNION`, and `MAP` * DEC `STRUCTURE`, `RECORD`, with '%FILL'; but `UNION`, and `MAP`
are not yet supported throughout compilation, and elicit a are not yet supported throughout compilation, and elicit a
"not yet implemented" message. "not yet implemented" message.
* Structure field access with `.field` * Structure field access with `.field`
* `BYTE` as synonym for `INTEGER(KIND=1)` * `BYTE` as synonym for `INTEGER(KIND=1)`; but not when spelled `TYPE(BYTE)`.
* Quad precision REAL literals with `Q` * Quad precision REAL literals with `Q`
* `X` prefix/suffix as synonym for `Z` on hexadecimal literals * `X` prefix/suffix as synonym for `Z` on hexadecimal literals
* `B`, `O`, `Z`, and `X` accepted as suffixes as well as prefixes * `B`, `O`, `Z`, and `X` accepted as suffixes as well as prefixes
Context not available.

flang/lib/Parser/Fortran-parsers.cpp

Context not available.
// for TYPE (...), rather than putting the alternatives within it, which // for TYPE (...), rather than putting the alternatives within it, which
// would fail on "TYPE(real_derived)" with a misrecognition of "real" as an // would fail on "TYPE(real_derived)" with a misrecognition of "real" as an
// intrinsic-type-spec. // intrinsic-type-spec.
// N.B. TYPE(x) is a derived type if x is a one-word extension intrinsic
// type (BYTE or DOUBLECOMPLEX), not the extension intrinsic type.
TYPE_CONTEXT_PARSER("declaration type spec"_en_US, TYPE_CONTEXT_PARSER("declaration type spec"_en_US,
construct<DeclarationTypeSpec>(intrinsicTypeSpec) || construct<DeclarationTypeSpec>(intrinsicTypeSpec) ||
"TYPE" >> "TYPE" >>
(parenthesized(construct<DeclarationTypeSpec>(intrinsicTypeSpec)) || (parenthesized(construct<DeclarationTypeSpec>(
!"DOUBLECOMPLEX"_tok >> !"BYTE"_tok >> intrinsicTypeSpec)) ||
parenthesized(construct<DeclarationTypeSpec>( parenthesized(construct<DeclarationTypeSpec>(
construct<DeclarationTypeSpec::Type>(derivedTypeSpec))) || construct<DeclarationTypeSpec::Type>(derivedTypeSpec))) ||
construct<DeclarationTypeSpec>( construct<DeclarationTypeSpec>(
Context not available.
"LOGICAL" >> maybe(kindSelector))), "LOGICAL" >> maybe(kindSelector))),
extension<LanguageFeature::DoubleComplex>( extension<LanguageFeature::DoubleComplex>(
"nonstandard usage: DOUBLE COMPLEX"_port_en_US, "nonstandard usage: DOUBLE COMPLEX"_port_en_US,
construct<IntrinsicTypeSpec>("DOUBLE COMPLEX" >> construct<IntrinsicTypeSpec>("DOUBLE COMPLEX"_sptok >>
construct<IntrinsicTypeSpec::DoubleComplex>())), construct<IntrinsicTypeSpec::DoubleComplex>())),
extension<LanguageFeature::Byte>("nonstandard usage: BYTE"_port_en_US, extension<LanguageFeature::Byte>("nonstandard usage: BYTE"_port_en_US,
construct<IntrinsicTypeSpec>(construct<IntegerTypeSpec>( construct<IntrinsicTypeSpec>(construct<IntegerTypeSpec>(
Context not available.