[debugserver ] Un-conditionalize use of libcompression

[JDevlieghere]

Summary

Jason removed the include guards in 681f6c2f552fb9b57380f4bfd453e1fc9b6a099e. This removes the corresponding CMake logic.

[jasonmolenda]

I think we only support building debugserver on macOS systems that have libcompression. Was there a configuration where this resulted in an error? lldb needs to test for libcompression and use it if available, but with debugserver we assume it is available iirc. I'm fine with the patch, but I'm curious how it came up. It used to be tested before use etc but I removed that a couple of years ago when our minimum deployment target was high enough that it was always available.

[jasonmolenda]

fwiw,

commit 681f6c2f552fb9b57380f4bfd453e1fc9b6a099e
Author: Jason Molenda <[e-mail]>
Date:   Tue Dec 18 22:21:48 2018 +0000

    Un-conditionalize use of libcompression.  debugserver only builds
    on Darwin systems and libcompression has been in the OS for over
    three years.

[JDevlieghere]

That also works for me, but then let's remove the corresponding logic in CMake as well.

[jasonmolenda]

Sounds good. I think it's test-and-use for lldb, and debugserver ended up structure the same way.

lldb/tools/debugserver/source/RNBRemote.cpp

 #include "JSONGenerator.h"
 #include "MacOSX/Genealogy.h"
 #include "OsLogger.h"
 #include "RNBContext.h"
 #include "RNBServices.h"
 #include "RNBSocket.h"
 #include "StdStringExtractor.h"
 
+#if defined(HAVE_LIBCOMPRESSION)
 #include <compression.h>
+#endif
 
 #include <TargetConditionals.h>
 #include <algorithm>
 #include <iomanip>
 #include <memory>
 #include <sstream>
 #include <unordered_set>
 

 //
 //    N<original packet contents uncompressed>
 //    C<size of original decompressed packet>:<packet compressed with the
 //    requested compression scheme>
 //
 // If compression is not requested, the original packet contents are returned
 
 std::string RNBRemote::CompressString(const std::string &orig) {
+#if defined(HAVE_LIBCOMPRESSION)
   std::string compressed;
   compression_types compression_type = GetCompressionType();
   if (compression_type != compression_types::none) {
     bool compress_this_packet = false;
 
     if (orig.size() > m_compression_minsize) {
       compress_this_packet = true;
     }
if (compression_type != compression_types::none) {
     } else {
       compressed = "N" + orig;
     }
   } else {
     compressed = orig;
   }
 
   return compressed;
+#else
+  return orig;
+#endif
 }
 
 rnb_err_t RNBRemote::SendPacket(const std::string &s) {
   DNBLogThreadedIf(LOG_RNB_MAX, "%8d RNBRemote::%s (%s) called",
                    (uint32_t)m_comm.Timer().ElapsedMicroSeconds(true),
                    __FUNCTION__, s.c_str());
 
   std::string s_compressed = CompressString(s);