This is an archive of the discontinued LLVM Phabricator instance.

Differential D123610

[Testing] Drop clangTesting from clang's public library interface
ClosedPublic

Authored by sammccall on Apr 12 2022, 7:27 AM.

Details

Reviewers
hokein
Commits
rG4cec789c177d: [Testing] Drop clangTesting from clang's public library interface
Summary

This was probably not particularly intended to be public, and disallows deps
on gtest which are useful in test helpers.

https://discourse.llvm.org/t/stop-exporting-clangtesting-library/61672

Diff Detail

Event Timeline

sammccall created this revision.Apr 12 2022, 7:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2022, 7:27 AM
Herald added a subscriber: mgorny. · View Herald Transcript
sammccall requested review of this revision.Apr 12 2022, 7:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2022, 7:27 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B159237: Diff 422226.Apr 12 2022, 7:53 AM
hokein accepted this revision.Apr 12 2022, 12:14 PM

The change makes sense to me.

clang/lib/Testing/CMakeLists.txt
6

OOO, what is clang_TLL?

7

no related to this patch, I think clangTestingSupport is a better name (also align with the LLVM one).

This revision is now accepted and ready to land.Apr 12 2022, 12:14 PM
sammccall added inline comments.Apr 20 2022, 4:11 AM
clang/lib/Testing/CMakeLists.txt
6

clang_target_link_libraries, spelled it out

7

The LLVM one is called that because it's in llvm/Testing/Support, because it's associated with llvm/Support (but not all the parts are!).
There's nothing else in llvm/Testing, I think it should probably be flattened out instead.

This revision was landed with ongoing or failed builds.Apr 20 2022, 4:29 AM
Closed by commit rG4cec789c177d: [Testing] Drop clangTesting from clang's public library interface (authored by sammccall). · Explain Why
This revision was automatically updated to reflect the committed changes.
sammccall added a commit: rG4cec789c177d: [Testing] Drop clangTesting from clang's public library interface.

Revision Contents

PathSize
clang/
lib/
4 lines
Testing/
9 lines
unittests/
AST/
2 lines
ASTMatchers/
2 lines
Dynamic/
6 lines
Analysis/
2 lines
FlowSensitive/
2 lines
Sema/
2 lines
StaticAnalyzer/
6 lines
Tooling/
Syntax/
2 lines

Diff 423869

clang/lib/CMakeLists.txt

Show All 19 Lines
add_subdirectory(Frontend) add_subdirectory(Frontend)
add_subdirectory(FrontendTool) add_subdirectory(FrontendTool)
add_subdirectory(Tooling) add_subdirectory(Tooling)
add_subdirectory(DirectoryWatcher) add_subdirectory(DirectoryWatcher)
add_subdirectory(Index) add_subdirectory(Index)
add_subdirectory(IndexSerialization) add_subdirectory(IndexSerialization)
add_subdirectory(StaticAnalyzer) add_subdirectory(StaticAnalyzer)
add_subdirectory(Format) add_subdirectory(Format)
if(CLANG_INCLUDE_TESTS)
add_subdirectory(Testing) add_subdirectory(Testing)
endif()
add_subdirectory(Interpreter) add_subdirectory(Interpreter)

clang/lib/Testing/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Support Support
) )
add_clang_library(clangTesting # Not add_clang_library: this is not part of clang's public library interface.
# Unit tests should depend on this with target_link_libraries(), rather
hokeinUnsubmitted
Not Done
ReplyInline Actions

OOO, what is clang_TLL?

hokein: OOO, what is `clang_TLL`?
sammccallAuthorUnsubmitted
Done
ReplyInline Actions

clang_target_link_libraries, spelled it out

sammccall: clang_target_link_libraries, spelled it out
# than with clang_target_link_libraries().
hokeinUnsubmitted
Not Done
ReplyInline Actions

no related to this patch, I think clangTestingSupport is a better name (also align with the LLVM one).

hokein: no related to this patch, I think `clangTestingSupport` is a better name (also align with the…
sammccallAuthorUnsubmitted
Done
ReplyInline Actions

The LLVM one is called that because it's in llvm/Testing/Support, because it's associated with llvm/Support (but not all the parts are!).
There's nothing else in llvm/Testing, I think it should probably be flattened out instead.

sammccall: The LLVM one is called that because it's in llvm/Testing/Support, because it's associated with…
add_llvm_library(clangTesting
CommandLineArgs.cpp CommandLineArgs.cpp
BUILDTREE_ONLY
LINK_COMPONENTS
Support
) )

clang/unittests/AST/CMakeLists.txt

Show All 37 Lines
clang_target_link_libraries(ASTTests clang_target_link_libraries(ASTTests
PRIVATE PRIVATE
clangAST clangAST
clangASTMatchers clangASTMatchers
clangBasic clangBasic
clangFrontend clangFrontend
clangLex clangLex
clangSerialization clangSerialization
clangTesting
clangTooling clangTooling
) )
target_link_libraries(ASTTests target_link_libraries(ASTTests
PRIVATE PRIVATE
clangTesting
LLVMTestingSupport LLVMTestingSupport
) )

clang/unittests/ASTMatchers/CMakeLists.txt

Show All 12 Lines
clang_target_link_libraries(ASTMatchersTests clang_target_link_libraries(ASTMatchersTests
PRIVATE PRIVATE
clangAST clangAST
clangASTMatchers clangASTMatchers
clangBasic clangBasic
clangFrontend clangFrontend
clangSerialization clangSerialization
clangTesting
clangTooling clangTooling
) )
target_link_libraries(ASTMatchersTests target_link_libraries(ASTMatchersTests
PRIVATE PRIVATE
clangTesting
LLVMTestingSupport LLVMTestingSupport
) )
add_subdirectory(Dynamic) add_subdirectory(Dynamic)

clang/unittests/ASTMatchers/Dynamic/CMakeLists.txt

Show All 11 Lines
clang_target_link_libraries(DynamicASTMatchersTests clang_target_link_libraries(DynamicASTMatchersTests
PRIVATE PRIVATE
clangAST clangAST
clangASTMatchers clangASTMatchers
clangBasic clangBasic
clangDynamicASTMatchers clangDynamicASTMatchers
clangFrontend clangFrontend
clangSerialization clangSerialization
clangTesting
clangTooling clangTooling
) )
target_link_libraries(DynamicASTMatchersTests
PRIVATE
clangTesting
)

clang/unittests/Analysis/CMakeLists.txt

Show All 14 Linesclang_target_link_libraries(ClangAnalysisTests
PRIVATE PRIVATE
clangAnalysis clangAnalysis
clangAST clangAST
clangASTMatchers clangASTMatchers
clangBasic clangBasic
clangFrontend clangFrontend
clangLex clangLex
clangSerialization clangSerialization
clangTesting
clangTooling clangTooling
) )
target_link_libraries(ClangAnalysisTests target_link_libraries(ClangAnalysisTests
PRIVATE PRIVATE
clangTesting
LLVMTestingSupport LLVMTestingSupport
) )
add_subdirectory(FlowSensitive) add_subdirectory(FlowSensitive)

clang/unittests/Analysis/FlowSensitive/CMakeLists.txt

Show All 25 Linesclang_target_link_libraries(ClangAnalysisFlowSensitiveTests
clangAnalysisFlowSensitive clangAnalysisFlowSensitive
clangAnalysisFlowSensitiveModels clangAnalysisFlowSensitiveModels
clangAST clangAST
clangASTMatchers clangASTMatchers
clangBasic clangBasic
clangFrontend clangFrontend
clangLex clangLex
clangSerialization clangSerialization
clangTesting
clangTooling clangTooling
) )
target_link_libraries(ClangAnalysisFlowSensitiveTests target_link_libraries(ClangAnalysisFlowSensitiveTests
PRIVATE PRIVATE
clangTesting
LLVMTestingSupport LLVMTestingSupport
) )

clang/unittests/Sema/CMakeLists.txt

Show All 13 Linesclang_target_link_libraries(SemaTests
PRIVATE PRIVATE
clangAST clangAST
clangASTMatchers clangASTMatchers
clangBasic clangBasic
clangFrontend clangFrontend
clangParse clangParse
clangSema clangSema
clangSerialization clangSerialization
clangTesting
clangTooling clangTooling
) )
target_link_libraries(SemaTests target_link_libraries(SemaTests
PRIVATE PRIVATE
clangTesting
LLVMTestingSupport LLVMTestingSupport
) )

clang/unittests/StaticAnalyzer/CMakeLists.txt

Show All 25 Linesclang_target_link_libraries(StaticAnalysisTests
clangAnalysis clangAnalysis
clangAST clangAST
clangASTMatchers clangASTMatchers
clangCrossTU clangCrossTU
clangFrontend clangFrontend
clangSerialization clangSerialization
clangStaticAnalyzerCore clangStaticAnalyzerCore
clangStaticAnalyzerFrontend clangStaticAnalyzerFrontend
clangTesting
clangTooling clangTooling
) )
target_link_libraries(StaticAnalysisTests
PRIVATE
clangTesting
)

clang/unittests/Tooling/Syntax/CMakeLists.txt

Show All 12 Lines
clang_target_link_libraries(SyntaxTests clang_target_link_libraries(SyntaxTests
PRIVATE PRIVATE
clangAST clangAST
clangBasic clangBasic
clangFrontend clangFrontend
clangLex clangLex
clangSerialization clangSerialization
clangTesting
clangTooling clangTooling
clangToolingCore clangToolingCore
clangToolingSyntax clangToolingSyntax
) )
target_link_libraries(SyntaxTests target_link_libraries(SyntaxTests
PRIVATE PRIVATE
clangTesting
LLVMTestingSupport LLVMTestingSupport
) )