This is an archive of the discontinued LLVM Phabricator instance.

[InstCombine] fix tests in fneg.ll
AbandonedPublic

Authored by Chenbing.Zheng on Apr 12 2022, 4:51 AM.

Details

Summary

Add flag 'nsz' in select, so that it can be fold to fabs.

In D101727, it fix Incorrect transformation of fabs, so I think
'nsz' should be added in select.

Diff Detail

Event Timeline

Chenbing.Zheng created this revision.Apr 12 2022, 4:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2022, 4:51 AM
Chenbing.Zheng requested review of this revision.Apr 12 2022, 4:51 AM

The TODO comment appears to be correct:
https://alive2.llvm.org/ce/z/Vwtz9q

So we should leave this test the same, but add another test that has 'nsz' on the select only?
https://alive2.llvm.org/ce/z/r_fPEu

If that sounds good, please commit an "NFC" patch to add one more test (no review on Phabricator is needed to add a test unless there are still open questions).

Chenbing.Zheng abandoned this revision.Apr 12 2022, 7:23 PM

The TODO comment appears to be correct:
https://alive2.llvm.org/ce/z/Vwtz9q

So we should leave this test the same, but add another test that has 'nsz' on the select only?
https://alive2.llvm.org/ce/z/r_fPEu

If that sounds good, please commit an "NFC" patch to add one more test (no review on Phabricator is needed to add a test unless there are still open questions).

Thanks for your explanation. I agree with you.