Page MenuHomePhabricator

[clang][extract-api] Emit "navigator" property of "name" in SymbolGraph
ClosedPublic

Authored by dang on Apr 8 2022, 7:59 AM.

Diff Detail

Event Timeline

dang created this revision.Apr 8 2022, 7:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2022, 7:59 AM
dang requested review of this revision.Apr 8 2022, 7:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2022, 7:59 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

This looks good! Just one question.

clang/test/ExtractAPI/objc_interface.m
204

I'm curious: Does this properly handle Objective-C methods with multiple arguments? i.e. if there were a method setProperty:andOtherProperty:, would that be the navigator name?

dang updated this revision to Diff 421537.Apr 8 2022, 8:44 AM

Add test to check that ObjC methods with multiple external parameters get the
correct name in subHeadings and navigator.

QuietMisdreavus accepted this revision.Apr 8 2022, 8:46 AM

Looks great, thanks!

This revision is now accepted and ready to land.Apr 8 2022, 8:46 AM
This revision was landed with ongoing or failed builds.Apr 8 2022, 9:29 AM
This revision was automatically updated to reflect the committed changes.