This is an archive of the discontinued LLVM Phabricator instance.

[demangler] Fold expressions of .* and ->*
ClosedPublic

Authored by urnathan on Apr 7 2022, 6:10 AM.

Details

Reviewers
dblaikie
iains
Group Reviewers
Restricted Project
Commits
rGed2d4da73200: [demangler] Fold expressions of .* and ->*
Summary

(Exitingly) a fold expression's operators include .* and ->*, but we failed to demangle them as we categorize those as MemberExprs, not BinaryExprs.

There is existing practice in the demangler to go looking at the actual token to perform specific actions, hence the peeking of the '*' char to distingish between MemberExpr alternatives here.

Diff Detail

Event Timeline

urnathan created this revision.Apr 7 2022, 6:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2022, 6:10 AM
urnathan requested review of this revision.Apr 7 2022, 6:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2022, 6:10 AM
urnathan updated this revision to Diff 425180.Apr 26 2022, 4:43 AM

rebase & ping?

dblaikie accepted this revision.Apr 26 2022, 9:51 AM

Sounds OK to me.

This revision is now accepted and ready to land.Apr 26 2022, 9:51 AM
This revision was landed with ongoing or failed builds.May 3 2022, 6:46 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2022, 6:46 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript