This is an archive of the discontinued LLVM Phabricator instance.

[NFC][CodeGen] Add comments for SDNode debug ID declaration
ClosedPublic

Authored by kovdan01 on Apr 6 2022, 11:03 AM.

Details

Summary

Normally, we place fields serving for debug purpose declarations
under #if LLVM_ENABLE_ABI_BREAKING_CHECKS. For SDNode::PersistentId and
SelectionDAG::NextPersistentId, we do not want to do so because it adds
unneeded complexity without noticeable benefits (see discussion with @thakis
in D120714). This patch adds comments describing why we don't place those
fields under #if not to confuse anyone more.

Diff Detail

Event Timeline

kovdan01 created this revision.Apr 6 2022, 11:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2022, 11:03 AM
kovdan01 requested review of this revision.Apr 6 2022, 11:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2022, 11:03 AM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 6 2022, 11:05 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.