This is an archive of the discontinued LLVM Phabricator instance.

[docs] Fix Kaleidoscope code example
ClosedPublic

Authored by r7vme on Apr 5 2022, 2:17 AM.

Details

Summary
  • replace virtual with override
  • use default like in full code example

Diff Detail

Event Timeline

r7vme created this revision.Apr 5 2022, 2:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2022, 2:17 AM
r7vme updated this revision to Diff 420420.Apr 5 2022, 2:29 AM

Ready for review

r7vme published this revision for review.Apr 5 2022, 2:39 AM
r7vme added a reviewer: lattner.

Hello, this is my first patch to LLVM. Let me know if anything else is needed.

Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2022, 2:39 AM
lattner accepted this revision.Apr 5 2022, 9:20 AM

Nice, welcome to the project!

This revision is now accepted and ready to land.Apr 5 2022, 9:20 AM
r7vme added a comment.Apr 5 2022, 12:51 PM

CI has passed. Could someone please merge this?

This revision was automatically updated to reflect the committed changes.
foad added a subscriber: foad.Apr 6 2022, 3:27 AM

CI has passed. Could someone please merge this?

Done! I copied the author information that you use as r7vme on github. I hope that's OK.

Thank you @foad! If you'd like to apply for commit access, plz follow the instructions in the llvm developer policy.