do not show the help window on first gui startup

[llunak]

Summary

It's rather annoying if it's there after every startup, and that 'Help (F6)' at the top should be enough to help people who don't know.

lldb/source/Core/IOHandlerCursesGUI.cpp

if (!m_app_ap) {
     variables_window_sp->SetDelegate(
         WindowDelegateSP(new FrameVariablesWindowDelegate(m_debugger)));
     TreeDelegateSP thread_delegate_sp(new ThreadsTreeDelegate(m_debugger));
     threads_window_sp->SetDelegate(WindowDelegateSP(
         new TreeWindowDelegate(m_debugger, thread_delegate_sp)));
     status_window_sp->SetDelegate(
         WindowDelegateSP(new StatusBarWindowDelegate(m_debugger)));
 
-    // Show the main help window once the first time the curses GUI is
-    // launched
-    static bool g_showed_help = false;
-    if (!g_showed_help) {
-      g_showed_help = true;
-      main_window_sp->CreateHelpSubwindow();
-    }
-
     // All colors with black background.
     init_pair(1, COLOR_BLACK, COLOR_BLACK);
     init_pair(2, COLOR_RED, COLOR_BLACK);
     init_pair(3, COLOR_GREEN, COLOR_BLACK);
     init_pair(4, COLOR_YELLOW, COLOR_BLACK);
     init_pair(5, COLOR_BLUE, COLOR_BLACK);
     init_pair(6, COLOR_MAGENTA, COLOR_BLACK);
     init_pair(7, COLOR_CYAN, COLOR_BLACK);

lldb/test/API/commands/gui/basic/TestGuiBasic.py

def test_gui(self):
 
         self.launch(executable=self.getBuildArtifact("a.out"), dimensions=(100,500))
         self.expect('br set -f main.c -p "// Break here"', substrs=["Breakpoint 1", "address ="])
         self.expect("run", substrs=["stop reason ="])
 
 
         escape_key = chr(27).encode()
 
-        # Start the GUI for the first time and check for the welcome window.
+        # Start the GUI.
         self.child.sendline("gui")
-        self.child.expect_exact("Welcome to the LLDB curses GUI.")
 
-        # Press escape to quit the welcome screen
-        self.child.send(escape_key)
-        # Press escape again to quit the gui
-        self.child.send(escape_key)
-        self.expect_prompt()
-
-        # Start the GUI a second time, this time we should have the normal GUI.
-        self.child.sendline("gui")
         # Check for GUI elements in the menu bar.
         self.child.expect_exact("Target")
         self.child.expect_exact("Process")
         self.child.expect_exact("Thread")
         self.child.expect_exact("View")
         self.child.expect_exact("Help")
 
         # Check the sources window.

lldb/test/API/commands/gui/basicdebug/TestGuiBasicDebug.py

def test_gui(self):
         self.build()
 
         self.launch(executable=self.getBuildArtifact("a.out"), dimensions=(100,500))
         self.expect('br set -f main.c -p "// Break here"', substrs=["Breakpoint 1", "address ="])
         self.expect("run", substrs=["stop reason ="])
 
         escape_key = chr(27).encode()
 
-        # Start the GUI and close the welcome window.
+        # Start the GUI.
         self.child.sendline("gui")
-        self.child.expect("Welcome to the LLDB curses GUI.")
-        self.child.send(escape_key)
 
         # Simulate a simple debugging session.
         self.child.send("s") # step
         self.child.expect("return 1; // In function[^\r\n]+<<< Thread 1: step in")
         self.child.send("u") # up
         self.child.expect_exact("func(); // Break here")
         self.child.send("d") # down
         self.child.expect_exact("return 1; // In function")

lldb/test/API/commands/gui/breakpoints/TestGuiBreakpoints.py

def test_gui(self):
         self.expect("run", substrs=["stop reason ="])
 
         self.child.sendline("breakpoint list")
         self.child.expect_exact("No breakpoints currently set.")
 
         escape_key = chr(27).encode()
         down_key = chr(27)+'OB' # for vt100 terminal (lldbexpect sets TERM=vt100)
 
-        # Start the GUI and close the welcome window.
+        # Start the GUI.
         self.child.sendline("gui")
-        self.child.send(escape_key)
         self.child.expect_exact("Sources") # wait for gui
 
         # Go to next line, set a breakpoint.
         self.child.send(down_key)
         self.child.send('b')
         self.child.send(escape_key)
         self.expect_prompt()
         self.child.sendline("breakpoint list")

lldb/test/API/commands/gui/viewlarge/TestGuiViewLarge.py

def test_gui(self):
         self.expect('br set -f main.c -p "// Break here"', substrs=["Breakpoint 1", "address ="])
         self.expect("run", substrs=["stop reason ="])
 
         escape_key = chr(27).encode()
         left_key = chr(27)+'OD' # for vt100 terminal (lldbexpect sets TERM=vt100)
         right_key = chr(27)+'OC'
         ctrl_l = chr(12)
 
-        # Start the GUI and close the welcome window.
+        # Start the GUI.
         self.child.sendline("gui")
-        self.child.send(escape_key)
 
         # Check the sources window.
         self.child.expect_exact("Sources")
         # The string is copy&pasted from a 80-columns terminal. It will be followed by some
         # kind of an escape sequence (color, frame, etc.).
         self.child.expect_exact("int a_variable_with_a_very_looooooooooooooooooooooooooo"+chr(27))
         # The escape here checks that there's no content drawn by the previous line.
         self.child.expect_exact("int shortvar = 1;"+chr(27))