This is an archive of the discontinued LLVM Phabricator instance.

Remove wrong warning. Fix for https://github.com/llvm/llvm-project/issues/54625
Needs ReviewPublic

Authored by zahiraam on Apr 3 2022, 4:59 AM.

Details

Summary

When driver's floating-point options change, the user is made aware via a diagnostic. In the case of combining a fast math option with a non-fast option there should be no diagnostic. This patch removes the wrong diagnostic.
This is a fix for https://github.com/llvm/llvm-project/issues/54625.

Diff Detail

Event Timeline

zahiraam created this revision.Apr 3 2022, 4:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2022, 4:59 AM
zahiraam requested review of this revision.Apr 3 2022, 4:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2022, 4:59 AM
Herald added a subscriber: MaskRay. · View Herald Transcript
MaskRay added a comment.EditedApr 8 2022, 1:37 PM

Remove wrong warning. Fix for https://github.com/llvm/llvm-project/issues/54625

It's sufficient to reference https://github.com/llvm/llvm-project/issues/54625 in the commit message body.
For the subject line, just use some shorter IDs, e.g. issue 54625

It's somewhat conventional to use [Driver] tag for clang/lib/Driver changes.