This is an archive of the discontinued LLVM Phabricator instance.

Differential D122916

Vim Command
AcceptedPublic

Authored by ps-19 on Apr 1 2022, 9:43 AM.

Details

Reviewers
ktkachov
kbarton
beanz
aaron.ballman
Summary

Corrected a vim command, which was causing error when trying to build.

As per https://vi.stackexchange.com/questions/6265/usage-of-the-operator the operator is actually "=~?" not "=?".

Diff Detail

Unit TestsFailed

TimeTest
60,030 msx64 debian > MLIR.Examples/standalone::test.toy
60,030 msx64 debian > libFuzzer.libFuzzer::large.test

Event Timeline

ps-19 created this revision.Apr 1 2022, 9:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2022, 9:43 AM
ps-19 requested review of this revision.Apr 1 2022, 9:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2022, 9:43 AM
Harbormaster completed remote builds in B157438: Diff 419787.Apr 1 2022, 10:28 AM
aaron.ballman resigned from this revision.Apr 1 2022, 10:55 AM

I'm not qualified to review this (I know almost nothing about vim)

beanz accepted this revision.Apr 1 2022, 12:23 PM

This looks correct to me.

This revision is now accepted and ready to land.Apr 1 2022, 12:23 PM
ps-19 retitled this revision from Vim Syntax Error to Vim Command.Apr 3 2022, 5:16 AM
ps-19 edited the summary of this revision. (Show Details)
ps-19 mentioned this in D122990: Added new file & improved inclusivity.

Revision Contents

PathSize
llvm/
utils/
vim/
indent/
2 lines

Diff 419787

llvm/utils/vim/indent/llvm.vim

Context not available.
" Find a non-blank not-completely commented line above the current line. " Find a non-blank not-completely commented line above the current line.
let prev_lnum = prevnonblank(v:lnum - 1) let prev_lnum = prevnonblank(v:lnum - 1)
while prev_lnum > 0 && synIDattr(synID(prev_lnum, indent(prev_lnum)+1, 0), "name") =? "string\|comment" while prev_lnum > 0 && synIDattr(synID(prev_lnum, indent(prev_lnum)+1, 0), "name") =~? "string\|comment"
let prev_lnum = prevnonblank(prev_lnum-1) let prev_lnum = prevnonblank(prev_lnum-1)
endwhile endwhile
" Hit the start of the file, use zero indent. " Hit the start of the file, use zero indent.
Context not available.