[libcxx] Add some missing xlocale wrapper functions for OpenBSD

[brad]

Summary

When updating OpenColorIO it was noticed that the function strtol_l() was missing and looking around I see strtoul_l() was also missing.

[brad]

Formatting and style fixes.

[brad]

ping.

[Mordante]

I wonder whether this only affects OpenBSD or other platforms as well. If it also affects other platforms should these functions be here or in _support/xlocale/__strtonum_fallback.h?

libcxx/include/__support/openbsd/xlocale.h

24

Why the static inline instead of inline?
Please add _LIBCPP_HIDE_FROM_ABI.

[brad]

In D122861#3433609, @Mordante wrote:

I wonder whether this only affects OpenBSD or other platforms as well. If it also affects other platforms should these functions be here or in _support/xlocale/__strtonum_fallback.h?

I was wondering about that as well, but thought I should keep this specific to OpenBSD for now to reduce the likelihood of something breaking and can be expanded later if desired.

[brad]

libcxx/include/__support/openbsd/xlocale.h

24

Why the static inline instead of inline?
Please add _LIBCPP_HIDE_FROM_ABI.

I copied bits from libcxx/include/__support/solaris/xlocale.h, but the same goes for libcxx/include/__support/ibm/xlocale.h and libcxx/include/__support/musl/xlocale.h.

I don't see _LIBCPP_HIDE_FROM_ABI used anywhere in that sub-dir.

[Mordante]

In D122861#3434764, @brad wrote:

In D122861#3433609, @Mordante wrote:

I wonder whether this only affects OpenBSD or other platforms as well. If it also affects other platforms should these functions be here or in _support/xlocale/__strtonum_fallback.h?

I was wondering about that as well, but thought I should keep this specific to OpenBSD for now to reduce the likelihood of something breaking and can be expanded later if desired.

Fair point.

libcxx/include/__support/openbsd/xlocale.h

24

This is used in _support/xlocale/__strtonum_fallback.h

inline _LIBCPP_INLINE_VISIBILITY long long                                      
strtoll_l(const char *nptr, char **endptr, int base, locale_t) {
  return ::strtoll(nptr, endptr, base);
}

Note that _LIBCPP_INLINE_VISIBILITY is the deprecated name for _LIBCPP_HIDE_FROM_ABI

@ldionne Do you know why these locale headers use static inline instead of inline LIBCPP_HIDE_FROM_ABI?

[ldionne]

libcxx/include/__support/openbsd/xlocale.h

24

I don't know why, but it's certainly unusual for us to define static inline functions in headers. I think this should be inline only (and _LIBCPP_HIDE_ROM_ABI like everything else).

Edit: It might be because those are meant to bridge a gap between the C headers on the system, and that's a C like way of defining those functions? Regardless, I think we should go for just inline.

[brad]

Update based on feedback.

[brad]

ping.

[brad]

ping.

[Mordante]

Sorry I missed your previous ping. LGTM!

libcxx/include/__support/openbsd/xlocale.h

 #define _LIBCPP_SUPPORT_OPENBSD_XLOCALE_H
 
 #include <__support/xlocale/__strtonum_fallback.h>
 #include <clocale>
 #include <cstdlib>
 #include <ctype.h>
 #include <cwctype>
 
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+
+static inline long strtol_l(const char *nptr, char **endptr, int base,
+                            locale_t) {
+  return strtol(nptr, endptr, base);
+}
+
+static inline unsigned long strtoul_l(const char *nptr, char **endptr,
+                                      int base, locale_t) {
+  return strtoul(nptr, endptr, base);
+}
+
+
+#ifdef __cplusplus
+}
+#endif
+
 #endif