This is an archive of the discontinued LLVM Phabricator instance.

Differential D122785

chore: add watermark test for llvm-cov
ClosedPublic

Authored by tanjinhua on Mar 30 2022, 11:59 PM.

Details

Reviewers
phosek
davidxl
Commits
rGd17c7cc53812: [llvm-cov] Add test cases for coverage_watermark
Summary

Add some test for llvm-cov's watermark.
In fact the test case has request in https://reviews.llvm.org/D116876#3266911 and I have push it since https://reviews.llvm.org/D116876#3278739. But it seems that it has lost since push to Github repo.

Diff Detail

Event Timeline

tanjinhua created this revision.Mar 30 2022, 11:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2022, 11:59 PM
tanjinhua requested review of this revision.Mar 30 2022, 11:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2022, 11:59 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
tanjinhua edited the summary of this revision. (Show Details)Mar 31 2022, 12:14 AM
tanjinhua added reviewers: phosek, davidxl.
phosek accepted this revision.Mar 31 2022, 12:50 AM

LGTM

This revision is now accepted and ready to land.Mar 31 2022, 12:50 AM
davidxl accepted this revision.Mar 31 2022, 8:36 AM

lgtm

Harbormaster completed remote builds in B157106: Diff 419342.Mar 31 2022, 8:58 AM
This revision was landed with ongoing or failed builds.Mar 31 2022, 8:55 PM
Closed by commit rGd17c7cc53812: [llvm-cov] Add test cases for coverage_watermark (authored by Tan Jinhua <jinhua.tan@bytedance.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.
Tan Jinhua <jinhua.tan@bytedance.com> added a commit: rGd17c7cc53812: [llvm-cov] Add test cases for coverage_watermark.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-cov/
41 lines

Diff 419614

llvm/test/tools/llvm-cov/coverage_watermark.test

  • This file was added.
RUN: not llvm-cov show --instr-profile=/dev/null -coverage-watermark=foo /dev/null 2>&1 | FileCheck --check-prefix=INVALID-ARG %s
INVALID-ARG: error: -coverage-watermark: invalid argument 'foo', must be in format 'high,low'
RUN: not llvm-cov show --instr-profile=/dev/null -coverage-watermark=a,2 /dev/null 2>&1 | FileCheck --check-prefix=INVALID-HIGH %s
INVALID-HIGH: error: -coverage-watermark: invalid number 'a', invalid value for 'high'
RUN: not llvm-cov show --instr-profile=/dev/null -coverage-watermark=10,b /dev/null 2>&1 | FileCheck --check-prefix=INVALID-LOW %s
INVALID-LOW: error: -coverage-watermark: invalid number 'b', invalid value for 'low'
RUN: not llvm-cov show --instr-profile=/dev/null -coverage-watermark=10,20 /dev/null 2>&1 | FileCheck --check-prefix=INVALID-ARRANGE %s
INVALID-ARRANGE: error: -coverage-watermark: invalid number range '10,20', must be both high and low should be between 0-100, and high > low
RUN: llvm-cov show %S/Inputs/templateInstantiations.covmapping -instr-profile %S/Inputs/templateInstantiations.profdata -format html -show-region-summary -show-instantiation-summary -o %t.html.dir -path-equivalence=/tmp,%S %S/showTemplateInstantiations.cpp
RUN: FileCheck -check-prefix=ORIGIN %s -input-file %t.html.dir/index.html
ORIGIN: <td class='column-entry-green'>
ORIGIN: 100.00% (3/3)
ORIGIN: <td class='column-entry-red'>
ORIGIN: 75.00% (9/12)
ORIGIN: <td class='column-entry-red'>
ORIGIN: 66.67% (4/6)
RUN: llvm-cov show %S/Inputs/templateInstantiations.covmapping -instr-profile %S/Inputs/templateInstantiations.profdata -format html -show-region-summary -show-instantiation-summary -o %t.html.dir -path-equivalence=/tmp,%S -coverage-watermark 80,60 %S/showTemplateInstantiations.cpp
RUN: FileCheck -check-prefix=DOWNGRADE1 %s -input-file %t.html.dir/index.html
DOWNGRADE1: <td class='column-entry-green'>
DOWNGRADE1: 100.00% (3/3)
DOWNGRADE1: <td class='column-entry-yellow'>
DOWNGRADE1: 75.00% (9/12)
DOWNGRADE1: <td class='column-entry-red'>
DOWNGRADE1: 66.67% (4/6)
RUN: llvm-cov show %S/Inputs/templateInstantiations.covmapping -instr-profile %S/Inputs/templateInstantiations.profdata -format html -show-region-summary -show-instantiation-summary -o %t.html.dir -path-equivalence=/tmp,%S -coverage-watermark 70,50 %S/showTemplateInstantiations.cpp
RUN: FileCheck -check-prefix=DOWNGRADE2 %s -input-file %t.html.dir/index.html
DOWNGRADE2: <td class='column-entry-green'>
DOWNGRADE2: 100.00% (3/3)
DOWNGRADE2: <td class='column-entry-green'>
DOWNGRADE2: 75.00% (9/12)
DOWNGRADE2: <td class='column-entry-yellow'>
DOWNGRADE2: 66.67% (4/6)