This is an archive of the discontinued LLVM Phabricator instance.

[cmake] fill `cmake_args` when crosscompiling external project with non-clang compiler
ClosedPublic

Authored by lxbndr on Mar 28 2022, 5:40 AM.

Details

Summary

This makes it possible to crosscompile runtimes with cl.exe on Windows.

An external project is completely misconfigured otherwise because cmake_args is set only for native builds or builds crosscompiled with clang.

Diff Detail

Event Timeline

lxbndr created this revision.Mar 28 2022, 5:40 AM
lxbndr created this object with edit policy "Administrators".
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2022, 5:40 AM
Herald added a subscriber: mgorny. · View Herald Transcript
lxbndr requested review of this revision.Mar 28 2022, 5:40 AM
lxbndr changed the visibility from "Public (No Login Required)" to "All Users".Mar 28 2022, 5:41 AM
lxbndr changed the visibility from "All Users" to "Public (No Login Required)".
lxbndr changed the edit policy from "Administrators" to "All Users".
compnerd accepted this revision.May 1 2022, 2:34 PM
This revision is now accepted and ready to land.May 1 2022, 2:34 PM
beanz accepted this revision.May 2 2022, 10:10 PM

LGTM. Thank you for a nice improvement!

This revision was landed with ongoing or failed builds.Jun 2 2022, 2:03 PM
This revision was automatically updated to reflect the committed changes.