This is an archive of the discontinued LLVM Phabricator instance.

Differential D122571

[libcxx] [test] Add missing header for std::numeric_limits
ClosedPublic

Authored by jwakely on Mar 28 2022, 4:15 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG89cacb9ee72c: [libcxx] [test] Add missing header for std::numeric_limits

Diff Detail

Event Timeline

jwakely created this revision.Mar 28 2022, 4:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2022, 4:15 AM
jwakely requested review of this revision.Mar 28 2022, 4:15 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 28 2022, 4:15 AM
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B156525: Diff 418542.Mar 28 2022, 5:51 AM
ldionne accepted this revision.Mar 28 2022, 11:18 AM
This revision is now accepted and ready to land.Mar 28 2022, 11:18 AM
jwakely added a comment.May 18 2022, 3:02 AM

I don't have commit access, could somebody push this on behalf of Jonathan Wakely <jwakely@redhat.com> please?

Closed by commit rG89cacb9ee72c: [libcxx] [test] Add missing header for std::numeric_limits (authored by jwakely, committed by bkramer). · Explain WhyMay 18 2022, 5:37 AM
This revision was automatically updated to reflect the committed changes.
bkramer added a commit: rG89cacb9ee72c: [libcxx] [test] Add missing header for std::numeric_limits.

Revision Contents

PathSize
libcxx/
test/
std/
iterators/
iterator.container/
1 line

Diff 418542

libcxx/test/std/iterators/iterator.container/ssize.pass.cpp

Show All 14 Lines
#include <iterator> #include <iterator>
#include <cassert> #include <cassert>
#include <vector> #include <vector>
#include <array> #include <array>
#include <list> #include <list>
#include <initializer_list> #include <initializer_list>
#include <string_view> #include <string_view>
#include <limits>
#include "test_macros.h" #include "test_macros.h"
// Ignore warning about std::numeric_limits comparisons being tautological. // Ignore warning about std::numeric_limits comparisons being tautological.
TEST_GCC_DIAGNOSTIC_IGNORED("-Wtype-limits") TEST_GCC_DIAGNOSTIC_IGNORED("-Wtype-limits")
struct short_container { struct short_container {
uint16_t size() const { return 60000; } // not noexcept uint16_t size() const { return 60000; } // not noexcept
▲ Show 20 Lines • Show All 91 Lines • Show Last 20 Lines